Skip to content

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Sep 10, 2025

Basic guardrail to get signal about whether the Buck setup works before PRs are imported.

Differential Revision: D82127666

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Copy link

pytorch-bot bot commented Sep 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14157

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 5 Unrelated Failures

As of commit 3531e91 with merge base 53b7ec5 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Sep 10, 2025
Basic guardrail to get signal about whether the Buck setup works before PRs are imported.


ghstack-source-id: 48d07fc
ghstack-comment-id: 3275605340
Pull-Request: #14157
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2025
@facebook-github-bot
Copy link
Contributor

@swolchok has imported this pull request. If you are a Meta employee, you can view this in D82121909.

# TODO: can't query //kernels/prim_ops because of non-buckified stuff in OSS.
buck2 query "//backends/apple/... + //backends/example/... + \
# TODO: Make //backends/arm tests use runtime wrapper so we can just query //backends/arm/...
buck2 query "//backends/apple/... + //backends/arm: + //backends/arm/debug/... + \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@zingo
Copy link
Collaborator

zingo commented Sep 10, 2025

Ohh this seems like it will help a lot, thanks

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Sep 10, 2025
Basic guardrail to get signal about whether the Buck setup works before PRs are imported.


ghstack-source-id: 63533f9
ghstack-comment-id: 3275605340
Pull-Request: #14157
@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@zingo
Copy link
Collaborator

zingo commented Sep 10, 2025

Arm backend sub test fails should be unrelated, i spoted that test randomly fail the other day a test rerun fixed it. Looking at our internal stats we detected it 1/70 runs the last 7 days.
The rtol/atol might need a small bump.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Sep 10, 2025
Basic guardrail to get signal about whether the Buck setup works before PRs are imported.


ghstack-source-id: 2ae3cbb
ghstack-comment-id: 3275605340
Pull-Request: #14157
@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Sep 10, 2025
Basic guardrail to get signal about whether the Buck setup works before PRs are imported.


ghstack-source-id: c55e94b
ghstack-comment-id: 3275605340
Pull-Request: #14157
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Sep 11, 2025
Basic guardrail to get signal about whether the Buck setup works before PRs are imported.


ghstack-source-id: ad58817
ghstack-comment-id: 3275605340
Pull-Request: #14157
@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@swolchok
Copy link
Contributor Author

Ohh this seems like it will help a lot, thanks

it doesn't build, run, or test, but it should be a lot better than nothing.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Sep 11, 2025
Basic guardrail to get signal about whether the Buck setup works before PRs are imported.


ghstack-source-id: ed481e3
ghstack-comment-id: 3275605340
Pull-Request: #14157
@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Sep 11, 2025
Basic guardrail to get signal about whether the Buck setup works before PRs are imported.


ghstack-source-id: 3121353
ghstack-comment-id: 3275605340
Pull-Request: #14157
@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@zingo zingo added the module: arm Issues related to arm backend label Sep 11, 2025
@swolchok
Copy link
Contributor Author

using a slightly bigger redder button to get this to land, should be soonish

Base automatically changed from gh/swolchok/564/head to gh/swolchok/562/head September 11, 2025 16:29
@facebook-github-bot facebook-github-bot merged commit 493de66 into gh/swolchok/562/head Sep 11, 2025
298 of 319 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/swolchok/565/head branch September 11, 2025 16:29
swolchok added a commit that referenced this pull request Sep 11, 2025
Differential Revision: D82127666

Pull Request resolved: #14157
swolchok added a commit that referenced this pull request Sep 11, 2025
Something went wrong with the automated merge here. This is an exact export of the corresponding diff.

Differential Revision: D82127666


ghstack-source-id: b1dae6c
ghstack-comment-id: 3282912510
Pull-Request: #14237
swolchok added a commit that referenced this pull request Sep 11, 2025
Something went wrong with the automated merge here. This is an exact
export of the corresponding diff.

Differential Revision: D82127666
swolchok added a commit that referenced this pull request Sep 12, 2025
Something went wrong with the automated merge here as well as the first manual merge. This is an exact export of the corresponding diff.

Differential Revision: D82127666


ghstack-source-id: 3829037
ghstack-comment-id: 3286290074
Pull-Request: #14267
swolchok added a commit that referenced this pull request Sep 12, 2025
Something went wrong with the automated merge here as well as the first
manual merge. This is an exact export of the corresponding diff.

Differential Revision: D82127666
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
Something went wrong with the automated merge here. This is an exact
export of the corresponding diff.

Differential Revision: D82127666
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
Something went wrong with the automated merge here as well as the first
manual merge. This is an exact export of the corresponding diff.

Differential Revision: D82127666
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
Something went wrong with the automated merge here. This is an exact
export of the corresponding diff.

Differential Revision: D82127666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants