Skip to content

Revert "Quantized Softmax Kernel" #14364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

Revert "Quantized Softmax Kernel" #14364

merged 1 commit into from
Sep 17, 2025

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Sep 17, 2025 •
edited
Loading

This reverts commit 94f62b7.

Not landed internally and failing internal tests here: D82596569, causing fix-up patch

@pytorch-bot pytorch-bot bot added the ci-no-td label Sep 17, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14364

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b1d3a45 with merge base ed482bd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 17, 2025
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@lucylq lucylq marked this pull request as ready for review September 17, 2025 01:25
@lucylq lucylq merged commit 56659e4 into main Sep 17, 2025
128 of 132 checks passed
@lucylq lucylq deleted the lfq.revert-14096 branch September 17, 2025 16:24
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
@lucylq @StrycekSimon
Revert "Quantized Softmax Kernel" (pytorch#14364)
b68bdd0 
This reverts commit 94f62b7.

Not landed internally and failing internal tests here:
[D82596569](https://www.internalfb.com/diff/D82596569), causing fix-up
patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mergennachin mergennachin mergennachin approved these changes

@skrtskrtfb skrtskrtfb Awaiting requested review from skrtskrtfb

@mcremon-meta mcremon-meta Awaiting requested review from mcremon-meta

@kirklandsign kirklandsign Awaiting requested review from kirklandsign

Assignees

No one assigned

Labels

ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucylq @mergennachin