-
Notifications
You must be signed in to change notification settings - Fork 699
[Cadence] move ETDump to OSS #14556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cadence] move ETDump to OSS #14556
Conversation
This diff moves the ETDump functionality to OSS by creating a new Python library, `etdump`, and exposing it to the Cadence backend. The new library is built in both `fbcode` and `xplat` and is included in the Cadence runtime. **Changes** * **fbcode/executorch/backends/cadence/runtime(targets.bzl)**: Addition of a new Python library, `etdump`, which includes the `etdump.py` file and specifies the visibility and dependencies. * **fbcode/executorch/backends/cadence/runtime(etdump.py)**: A new file that contains the `CadenceETDump` class, which is responsible for handling ETDump functionality. * **fbcode/executorch/backends/cadence/runtime(runtime.py)** and **xplat/executorch/backends/cadence/runtime(runtime.py)**: Modifications to the runtime to include the `CadenceETDump` class and remove unnecessary imports. * **xplat/executorch/backends/cadence/runtime(targets.bzl)**: Addition of a new Python library, `etdump`, which includes the `etdump.py` file and specifies the visibility and dependencies. Differential Revision: [D83188440](https://our.internmc.facebook.com/intern/diff/D83188440/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14556
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 1 Unrelated FailureAs of commit c96beeb with merge base 685e795 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This diff moves the ETDump functionality to OSS by creating a new Python library, `etdump`, and exposing it to the Cadence backend. The new library is built in both `fbcode` and `xplat` and is included in the Cadence runtime. **Changes** * **fbcode/executorch/backends/cadence/runtime(targets.bzl)**: Addition of a new Python library, `etdump`, which includes the `etdump.py` file and specifies the visibility and dependencies. * **fbcode/executorch/backends/cadence/runtime(etdump.py)**: A new file that contains the `CadenceETDump` class, which is responsible for handling ETDump functionality. * **fbcode/executorch/backends/cadence/runtime(runtime.py)** and **xplat/executorch/backends/cadence/runtime(runtime.py)**: Modifications to the runtime to include the `CadenceETDump` class and remove unnecessary imports. * **xplat/executorch/backends/cadence/runtime(targets.bzl)**: Addition of a new Python library, `etdump`, which includes the `etdump.py` file and specifies the visibility and dependencies. Differential Revision: [D83188440](https://our.internmc.facebook.com/intern/diff/D83188440/) ghstack-source-id: 311920557 Pull Request resolved: #14556
|
@zonglinpeng has exported this pull request. If you are a Meta employee, you can view the originating diff in D83188440. |
This PR needs a
|
8cd456a
into
gh/zonglinpeng/4/base
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #14556 by @zonglinpeng ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/zonglinpeng/4/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/zonglinpeng/4/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/zonglinpeng/4/orig @diff-train-skip-merge Co-authored-by: Zonglin Peng <zonglinpeng@fb.com>
Stack from ghstack (oldest at bottom):
This diff moves the ETDump functionality to OSS by creating a new Python library,
etdump, and exposing it to the Cadence backend. The new library is built in bothfbcodeandxplatand is included in the Cadence runtime.Changes
etdump, which includes theetdump.pyfile and specifies the visibility and dependencies.CadenceETDumpclass, which is responsible for handling ETDump functionality.CadenceETDumpclass and remove unnecessary imports.etdump, which includes theetdump.pyfile and specifies the visibility and dependencies.Differential Revision: D83188440