Skip to content

Conversation

@zonglinpeng
Copy link
Contributor

@zonglinpeng zonglinpeng commented Sep 24, 2025

Stack from ghstack (oldest at bottom):

This diff moves the ETDump functionality to OSS by creating a new Python library, etdump, and exposing it to the Cadence backend. The new library is built in both fbcode and xplat and is included in the Cadence runtime.

Changes

  • fbcode/executorch/backends/cadence/runtime(targets.bzl): Addition of a new Python library, etdump, which includes the etdump.py file and specifies the visibility and dependencies.
  • fbcode/executorch/backends/cadence/runtime(etdump.py): A new file that contains the CadenceETDump class, which is responsible for handling ETDump functionality.
  • fbcode/executorch/backends/cadence/runtime(runtime.py) and xplat/executorch/backends/cadence/runtime(runtime.py): Modifications to the runtime to include the CadenceETDump class and remove unnecessary imports.
  • xplat/executorch/backends/cadence/runtime(targets.bzl): Addition of a new Python library, etdump, which includes the etdump.py file and specifies the visibility and dependencies.

Differential Revision: D83188440

This diff moves the ETDump functionality to OSS by creating a new Python library, `etdump`, and exposing it to the Cadence backend. The new library is built in both `fbcode` and `xplat` and is included in the Cadence runtime.

**Changes**

*   **fbcode/executorch/backends/cadence/runtime(targets.bzl)**: Addition of a new Python library, `etdump`, which includes the `etdump.py` file and specifies the visibility and dependencies.
*   **fbcode/executorch/backends/cadence/runtime(etdump.py)**: A new file that contains the `CadenceETDump` class, which is responsible for handling ETDump functionality.
*   **fbcode/executorch/backends/cadence/runtime(runtime.py)** and **xplat/executorch/backends/cadence/runtime(runtime.py)**: Modifications to the runtime to include the `CadenceETDump` class and remove unnecessary imports.
*   **xplat/executorch/backends/cadence/runtime(targets.bzl)**: Addition of a new Python library, `etdump`, which includes the `etdump.py` file and specifies the visibility and dependencies.

Differential Revision: [D83188440](https://our.internmc.facebook.com/intern/diff/D83188440/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14556

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Unrelated Failure

As of commit c96beeb with merge base 685e795 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

zonglinpeng pushed a commit that referenced this pull request Sep 24, 2025
This diff moves the ETDump functionality to OSS by creating a new Python library, `etdump`, and exposing it to the Cadence backend. The new library is built in both `fbcode` and `xplat` and is included in the Cadence runtime.

**Changes**

*   **fbcode/executorch/backends/cadence/runtime(targets.bzl)**: Addition of a new Python library, `etdump`, which includes the `etdump.py` file and specifies the visibility and dependencies.
*   **fbcode/executorch/backends/cadence/runtime(etdump.py)**: A new file that contains the `CadenceETDump` class, which is responsible for handling ETDump functionality.
*   **fbcode/executorch/backends/cadence/runtime(runtime.py)** and **xplat/executorch/backends/cadence/runtime(runtime.py)**: Modifications to the runtime to include the `CadenceETDump` class and remove unnecessary imports.
*   **xplat/executorch/backends/cadence/runtime(targets.bzl)**: Addition of a new Python library, `etdump`, which includes the `etdump.py` file and specifies the visibility and dependencies.

Differential Revision: [D83188440](https://our.internmc.facebook.com/intern/diff/D83188440/)

ghstack-source-id: 311920557
Pull Request resolved: #14556
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 24, 2025
@facebook-github-bot
Copy link
Contributor

@zonglinpeng has exported this pull request. If you are a Meta employee, you can view the originating diff in D83188440.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@hsharma35 hsharma35 self-requested a review September 25, 2025 17:54
@facebook-github-bot facebook-github-bot merged commit 8cd456a into gh/zonglinpeng/4/base Sep 25, 2025
127 of 138 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/zonglinpeng/4/head branch September 25, 2025 22:02
mergennachin pushed a commit that referenced this pull request Sep 29, 2025
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #14556 by
@zonglinpeng
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/zonglinpeng/4/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/zonglinpeng/4/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/zonglinpeng/4/orig
@diff-train-skip-merge

Co-authored-by: Zonglin Peng <zonglinpeng@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants