Skip to content

Conversation

winskuo-quic
Copy link
Collaborator

Summary

  • Support Add/Sub with alpha values
  • Support Conv3d
  • Support TransposeConv3d

Test plan

UT added

Copy link

pytorch-bot bot commented Sep 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14618

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 5 New Failures

As of commit d6c6a28 with merge base 5fd66ee (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 26, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Support Conv3d and TransposeConv3d
@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/annotation_support branch from 1438a9f to d6c6a28 Compare September 26, 2025 03:29
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D83314665.

@winskuo-quic
Copy link
Collaborator Author

Hi @cccclai,
This PR should resolve some suite operator's failure.
It would be appreciated if you could guide me through the following:

  1. How could I see the most up-to-date suite operator results in mainline, like the pdf file you shared with us through email.
  2. Could you share the command to run the suite operator tests? The command I use is:
    python -m executorch.backends.test.suite.runner operators --flow qnn --filter "test_conv3d_basic_qnn".
    I can see op validation and preprocess is passing, however, I keep getting an unknown error at the end, causing the test to skip, as shown in the image below:
image

@cccclai
Copy link
Contributor

cccclai commented Sep 26, 2025

Hi @cccclai, This PR should resolve some suite operator's failure. It would be appreciated if you could guide me through the following:

  1. How could I see the most up-to-date suite operator results in mainline, like the pdf file you shared with us through email.
  2. Could you share the command to run the suite operator tests? The command I use is:
    python -m executorch.backends.test.suite.runner operators --flow qnn --filter "test_conv3d_basic_qnn".
    I can see op validation and preprocess is passing, however, I keep getting an unknown error at the end, causing the test to skip, as shown in the image below:
image

@GregoryComer can you share the steps?

@cccclai cccclai merged commit dcc3978 into pytorch:main Sep 26, 2025
126 of 131 checks passed
@cccclai
Copy link
Contributor

cccclai commented Sep 27, 2025

@winskuo-quic from the latest run, it seems the number improves https://github.com/pytorch/executorch/actions/runs/18053810243

1 similar comment
@cccclai
Copy link
Contributor

cccclai commented Sep 27, 2025

@winskuo-quic from the latest run, it seems the number improves https://github.com/pytorch/executorch/actions/runs/18053810243

@winskuo-quic
Copy link
Collaborator Author

@pytorchbot cherry-pick --onto release/1.0 -c regression

pytorchbot pushed a commit that referenced this pull request Oct 2, 2025
### Summary

- Support Add/Sub with alpha values
- Support Conv3d
- Support TransposeConv3d

### Test plan
UT added

(cherry picked from commit dcc3978)
@pytorchbot
Copy link
Collaborator

Cherry picking #14618

The cherry pick PR is at #14742 and it is recommended to link a regression cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@GregoryComer
Copy link
Member

https://github.com/pytorch/executorch/actions/runs/18053810243

Thanks for the fixes! I updated the README here with some more repro examples: https://github.com/pytorch/executorch/blob/main/backends/test/suite/README.md. I've also updated to use pytest, which should make it easier to run the tests.

Regarding skips on conv3d, that's effectively a pass. What's happening is that the operator or model has an undelegated conv3d, which we don't have a portable implementation for. If nothing is delegated, it gets considered a pass, as the backend worked as intended. If it's partially delegated and has missing portable ops, it's considered skipped as it can't test the model. But, from the backend perspective, it's passing. I should maybe just update the test logic to mark as pass instead of skip for this case.

@cccclai
Copy link
Contributor

cccclai commented Oct 2, 2025

I should maybe just update the test logic to mark as pass instead of skip for this case.

@GregoryComer yes let's do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants