Skip to content

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Oct 7, 2025

This reverts commit 750cba7.

Re-applying the better threadpool size defaults from #14090 with the fix from #14838. This gives a 2-4x speedup for many models and platforms (I measured 4x speedup on M1 with MobileNet V3 + XNNPACK). On high core count server platforms (doing evals, for example), this can give a 100x speedup out of box.

Copy link

pytorch-bot bot commented Oct 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14842

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Pending

As of commit 0cea48f with merge base 2672dd3 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 7, 2025
@GregoryComer GregoryComer force-pushed the reapply-thread-defaults branch 2 times, most recently from 7b16cb4 to 4db5e01 Compare October 7, 2025 21:19
@GregoryComer GregoryComer force-pushed the reapply-thread-defaults branch from 4db5e01 to 0cea48f Compare October 8, 2025 18:46
@GregoryComer GregoryComer marked this pull request as ready for review October 8, 2025 22:03
@GregoryComer GregoryComer added the release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) label Oct 8, 2025
@GregoryComer
Copy link
Member Author

Voxtral CI failure is due to running on a fork. Samsung failure is also pre-existing.

Copy link
Contributor

@kimishpatel kimishpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this is reapply. stamping

@GregoryComer
Copy link
Member Author

assuming this is reapply. stamping

Yeah, this is a direct re-apply of the previously landed PR. Thanks.

@GregoryComer GregoryComer merged commit a26412e into pytorch:main Oct 9, 2025
231 of 239 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants