Skip to content

Conversation

@sxu
Copy link
Contributor

@sxu sxu commented Oct 8, 2025

Summary: We should read from max_context_len for RoPE, max_seq_len represents input sequence length.

Differential Revision: D84182698

Summary: We should read from `max_context_len` for RoPE, `max_seq_len` represents input sequence length.

Differential Revision: D84182698
@sxu sxu requested review from jackzhxng and lucylq as code owners October 8, 2025 19:59
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14912

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 6 Cancelled Jobs

As of commit 4000264 with merge base c62cbfe (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 8, 2025

@sxu has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84182698.

@sxu sxu requested a review from billmguo October 8, 2025 19:59
@sxu sxu added the release notes: none Do not include this in the release notes label Oct 8, 2025
@meta-codesync meta-codesync bot merged commit 09c93d4 into pytorch:main Oct 9, 2025
138 of 160 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants