refactor cuda_backend.cpp #14926
Merged
refactor cuda_backend.cpp #14926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request resolved: #14904 This diff does a comprehensive refactor on cuda_backend.cpp. Two main points: 1. Reuse ExecuTorch standard macros (ET_CHECK_OR_RETURN_ERROR and others) to replaces exiting if..else + ET_LOG branches 2. Introduced LOAD_SYMBOL macro to concentrate the symbol loading pipeline. ghstack-source-id: 314984328 @exported-using-ghexport Differential Revision: [D84135844](https://our.internmc.facebook.com/intern/diff/D84135844/)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14926
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Gasoonjia
approved these changes
Oct 9, 2025
…ree (#14927) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #14905 by @Gasoonjia ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/50/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/50/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/49/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/50/orig Differential Revision: [D84135792](https://our.internmc.facebook.com/intern/diff/D84135792/) @diff-train-skip-merge --------- Co-authored-by: gasoonjia <gasoonjia@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #14904 by @Gasoonjia
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/49/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/49/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/47/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/49/orig
Differential Revision: D84135844
@diff-train-skip-merge