Make image and audio variables const references #15009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
requested review from
jackzhxng,
larryliu0820,
mergennachin and
swolchok
as code owners
This was referenced Oct 10, 2025
meta-cla
bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15009
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 5 PendingAs of commit e2facf7 with merge base e0dda90 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
larryliu0820
approved these changes
Oct 10, 2025
Bind the result of `get_image()` and `get_audio()` to const ref to avoid copy. (cherry picked from commit e26670b)
larryliu0820
force-pushed
the
cherry-pick-14999-by-pytorch_bot_bot_
branch
from
08d3200 to
e2facf7
Compare
digantdesai
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bind the result of
get_image()andget_audio()to const ref to avoid copy.