Skip to content

Revert "[ET-VK] Add Fusing for Conv/Binary Ops, Clamp/Binary Ops, and… #15066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2025
Merged

Revert "[ET-VK] Add Fusing for Conv/Binary Ops, Clamp/Binary Ops, and… #15066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b196b1e
Revert "[ET-VK] Add Fusing for Conv/Binary Ops, Clamp/Binary Ops, and…
JacobSzwejbka Oct 13, 2025
f185cf5
Merge branch 'main' into revert-vulkan-change
JacobSzwejbka Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 0 additions & 123 deletions backends/transforms/fuse_clamp_with_binary_op.py
View file
Open in desktop

This file was deleted.

105 changes: 0 additions & 105 deletions backends/transforms/fuse_clamps.py
View file
Open in desktop

This file was deleted.

10 changes: 1 addition & 9 deletions backends/transforms/fuse_conv_with_clamp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from executorch.exir.pass_base import ExportPass, PassResult


class FuseConvClampPass(ExportPass):
class FuseClampPass(ExportPass):
"""
Some activations like ReLU and hardtanh can be fused with certain operators (e.g. convolution) preceding it.
"""
Expand All @@ -25,7 +25,6 @@ class FuseConvClampPass(ExportPass):
FUSEABLE_ACTIVATIONS = [
exir_ops.edge.aten.relu.default,
exir_ops.edge.aten.hardtanh.default,
exir_ops.edge.aten.clamp.default,
]

def get_output_min_max_from_activation(self, activation_node):
Expand All @@ -38,13 +37,6 @@ def get_output_min_max_from_activation(self, activation_node):
if len(activation_node.args) > 1:
output_min = activation_node.args[1]
output_max = activation_node.args[2]
elif activation_node.target == exir_ops.edge.aten.clamp.default:
output_min = None
output_max = None
if len(activation_node.args) >= 2:
output_min = activation_node.args[1]
if len(activation_node.args) >= 3:
output_max = activation_node.args[2]

return output_min, output_max

Expand Down
32 changes: 0 additions & 32 deletions backends/transforms/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,38 +77,6 @@ def define_common_targets():
],
)

runtime.python_library(
name = "fuse_clamps",
srcs = ["fuse_clamps.py"],
visibility = [
"//executorch/backends/...",
],
deps = [
":utils",
"//caffe2:torch",
"//executorch/backends/vulkan:custom_ops_lib",
"//executorch/exir:pass_base",
"//executorch/exir:sym_util",
"//executorch/exir/dialects:lib",
],
)

runtime.python_library(
name = "fuse_clamp_with_binary_op",
srcs = ["fuse_clamp_with_binary_op.py"],
visibility = [
"//executorch/backends/...",
],
deps = [
":utils",
"//caffe2:torch",
"//executorch/backends/vulkan:custom_ops_lib",
"//executorch/exir:pass_base",
"//executorch/exir:sym_util",
"//executorch/exir/dialects:lib",
],
)

runtime.python_library(
name = "view_copy_to_squeeze_unsqueeze",
srcs = ["view_copy_to_squeeze_unsqueeze.py"],
Expand Down
Loading
Loading