[ET-VK] Removing manual unroll in linear shader to improve overall performance. #15110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15110
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit b19c6be with merge base 4c4f235 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@trivedivivek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84571616. |
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 14, 2025
…e. (pytorch#15110) Summary: ### Summary This diff improves the overall performance of the linear shader by removing manual unrolling in the `linear_qcsnw_tiled.glsl` file. The changes include: - Removing the `[[unroll]]` directive in the for loop to allow the compiler to automatically unroll the loop, which can lead to better performance. - Changing the type of `mat1` from `VEC4_T[TILE_ROWS]` to `T[TILE_ROWS][4]` to better match the access pattern in the loop. Differential Revision: D84571616
mergennachin
changed the title
trivedivivek
force-pushed
the
export-D84571616
branch
from
9c3d279 to
c1369bc
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 15, 2025
…e. (pytorch#15110) Summary: ### Summary This diff improves the overall performance of the linear shader by removing manual unrolling in the `linear_qcsnw_tiled.glsl` file. The changes include: - Removing the `[[unroll]]` directive in the for loop to allow the compiler to automatically unroll the loop, which can lead to better performance. - Changing the type of `mat1` from `VEC4_T[TILE_ROWS]` to `T[TILE_ROWS][4]` to better match the access pattern in the loop. Differential Revision: D84571616
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 15, 2025
…e. (pytorch#15110) Summary: ### Summary This diff improves the overall performance of the linear shader by removing manual unrolling in the `linear_qcsnw_tiled.glsl` file. The changes include: - Removing the `[[unroll]]` directive in the for loop to allow the compiler to automatically unroll the loop, which can lead to better performance. - Changing the type of `mat1` from `VEC4_T[TILE_ROWS]` to `T[TILE_ROWS][4]` to better match the access pattern in the loop. Differential Revision: D84571616
SS-JIA
approved these changes
Oct 15, 2025
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 15, 2025
…e. (pytorch#15110) Summary: ### Summary This diff improves the overall performance of the linear shader by removing manual unrolling in the `linear_qcsnw_tiled.glsl` file. The changes include: - Removing the `[[unroll]]` directive in the for loop to allow the compiler to automatically unroll the loop, which can lead to better performance. - Changing the type of `mat1` from `VEC4_T[TILE_ROWS]` to `T[TILE_ROWS][4]` to better match the access pattern in the loop. Reviewed By: SS-JIA Differential Revision: D84571616
trivedivivek
force-pushed
the
export-D84571616
branch
from
c1369bc to
280b330
Compare
trivedivivek
added
the
release notes: vulkan
…e. (pytorch#15110) Summary: ### Summary This diff improves the overall performance of the linear shader by removing manual unrolling in the `linear_qcsnw_tiled.glsl` file. The changes include: - Removing the `[[unroll]]` directive in the for loop to allow the compiler to automatically unroll the loop, which can lead to better performance. - Changing the type of `mat1` from `VEC4_T[TILE_ROWS]` to `T[TILE_ROWS][4]` to better match the access pattern in the loop. Reviewed By: SS-JIA Differential Revision: D84571616
trivedivivek
force-pushed
the
export-D84571616
branch
from
280b330 to
b19c6be
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 15, 2025
…e. (pytorch#15110) Summary: ### Summary This diff improves the overall performance of the linear shader by removing manual unrolling in the `linear_qcsnw_tiled.glsl` file. The changes include: - Removing the `[[unroll]]` directive in the for loop to allow the compiler to automatically unroll the loop, which can lead to better performance. - Changing the type of `mat1` from `VEC4_T[TILE_ROWS]` to `T[TILE_ROWS][4]` to better match the access pattern in the loop. Reviewed By: SS-JIA Differential Revision: D84571616
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 15, 2025
…e. (pytorch#15110) Summary: ### Summary This diff improves the overall performance of the linear shader by removing manual unrolling in the `linear_qcsnw_tiled.glsl` file. The changes include: - Removing the `[[unroll]]` directive in the for loop to allow the compiler to automatically unroll the loop, which can lead to better performance. - Changing the type of `mat1` from `VEC4_T[TILE_ROWS]` to `T[TILE_ROWS][4]` to better match the access pattern in the loop. Reviewed By: SS-JIA Differential Revision: D84571616
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Summary
This diff improves the overall performance of the linear shader by removing manual unrolling in the
linear_qcsnw_tiled.glslfile.The changes include:
[[unroll]]directive in the for loop to allow the compiler to automatically unroll the loop, which can lead to better performance.mat1fromVEC4_T[TILE_ROWS]toT[TILE_ROWS][4]to better match the access pattern in the loop.Differential Revision: D84571616