audio float API #15214
Merged
audio float API #15214
+48
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15214
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 6 PendingAs of commit 7dd5801 with merge base caa35f6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
larryliu0820
approved these changes
Oct 17, 2025
psiddh
reviewed
Oct 17, 2025
| return static_cast<jint>(Error::EndOfMethod); | ||
| } | ||
| auto data_size = data->size(); | ||
| if (data_size != 0) { |
Contributor
There was a problem hiding this comment.
So is this condition ' if (data_size == 0) {' also considered ok / success in this flow ? We seem to return ok at Ln 362
Contributor
Author
There was a problem hiding this comment.
Good point. We can add a check in java. I just don't want it crash here.
kirklandsign
added
module: android
Member
|
@pytorchbot cherry-pick --onto release/1.0 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
Oct 17, 2025
Some audio inputs are float[] (cherry picked from commit df37d29)
Collaborator
Cherry picking #15214The cherry pick PR is at #15234 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some audio inputs are float[]
Test plan
CI
cc @cbilgin