Skip to content

Conversation

@JacobSzwejbka
Copy link
Contributor

Summary

Some fixes to make it compile on msvc

Test plan

will be adding full ci for msvc builds after all the changes are landed

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15224

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 6 Pending, 1 Unrelated Failure

As of commit fe5da0a with merge base 173b046 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@JacobSzwejbka JacobSzwejbka requested review from GregoryComer and removed request for digantdesai, kirklandsign and larryliu0820 October 17, 2025 18:15
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@JacobSzwejbka JacobSzwejbka merged commit 7c759cf into main Oct 17, 2025
137 of 138 checks passed
@JacobSzwejbka JacobSzwejbka deleted the xnnpack-msvc branch October 17, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants