Fix conv2d bias INT48 type hint removed by fusing placeholder nods #15257
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15257
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit baca2d0 with merge base 788ef2f ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 19, 2025
…15257) Summary: Fix conv2d bias INT48 type hint removed by fusing placeholder nods Reviewed By: Ninja91 Differential Revision: D84948170
facebook-github-bot
force-pushed
the
export-D84948170
branch
from
76b5cb1 to
7cdc650
Compare
digantdesai
reviewed
Oct 20, 2025
| common_persistent, | ||
| ) | ||
|
|
||
| # TBD: Find a principled way to merge node.meta across all fused node |
There was a problem hiding this comment.
Yeah this is a problem for 'non-standard' meta keys.
There was a problem hiding this comment.
Is there a way to write a conv2d test which fails without this change, just to safeguard.
3l1
added a commit
that referenced
this pull request
Oct 22, 2025
…15257) Summary: Fix conv2d bias INT48 type hint removed by fusing placeholder nods Reviewed By: Ninja91, digantdesai Differential Revision: D84948170
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 22, 2025
…15257) Summary: Fix conv2d bias INT48 type hint removed by fusing placeholder nods bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Reviewed By: Ninja91, digantdesai Differential Revision: D84948170
facebook-github-bot
force-pushed
the
export-D84948170
branch
from
dcc57e0 to
753d2d3
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 22, 2025
…15257) Summary: Fix conv2d bias INT48 type hint removed by fusing placeholder nods bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Reviewed By: Ninja91, digantdesai Differential Revision: D84948170
facebook-github-bot
force-pushed
the
export-D84948170
branch
from
753d2d3 to
68d5519
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 22, 2025
…15257) Summary: Fix conv2d bias INT48 type hint removed by fusing placeholder nods bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Reviewed By: Ninja91, digantdesai Differential Revision: D84948170
facebook-github-bot
force-pushed
the
export-D84948170
branch
from
68d5519 to
6bcc5ef
Compare
…15257) Summary: Fix conv2d bias INT48 type hint removed by fusing placeholder nods bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Reviewed By: Ninja91, digantdesai Differential Revision: D84948170
facebook-github-bot
force-pushed
the
export-D84948170
branch
from
6bcc5ef to
baca2d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix conv2d bias INT48 type hint removed by fusing placeholder nods
Reviewed By: Ninja91
Differential Revision: D84948170