Skip to content

Remove workaround for ovr_config//os:iphoneos not working in OSS #15263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove workaround for ovr_config//os:iphoneos not working in OSS #15263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions extension/threadpool/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@ def define_common_targets():

runtime.cxx_library(
name = "threadpool",
# TODO: OSS doesn't have os:iphoneos. Sync buck2 prelude
# update to add it and remove duplication.
exported_deps = (select({
exported_deps = select({
# Major operating systems should be able to use threadpool.
"ovr_config//os:linux": [":threadpool_lib"],
"ovr_config//os:macos": [":threadpool_lib"],
Expand All @@ -60,17 +58,7 @@ def define_common_targets():
"ovr_config//os:none": ["//executorch/runtime/kernel:thread_parallel_interface"],
# If we don't know what it is, disable threadpool out of caution.
"DEFAULT": ["//executorch/runtime/kernel:thread_parallel_interface"],
}) if not runtime.is_oss else select({
# Major operating systems should be able to use threadpool.
"ovr_config//os:linux": [":threadpool_lib"],
"ovr_config//os:macos": [":threadpool_lib"],
"ovr_config//os:windows": [":threadpool_lib"],
"ovr_config//os:android": [":threadpool_lib"],
# Machines without an operating system shouldn't.
"ovr_config//os:none": ["//executorch/runtime/kernel:thread_parallel_interface"],
# If we don't know what it is, disable threadpool out of caution.
"DEFAULT": ["//executorch/runtime/kernel:thread_parallel_interface"],
})),
}),
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
Expand Down
Loading