Skip to content

Conversation

pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #15158 by @SS-JIA
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/341/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/341/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/340/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/341/orig
Differential Revision: D84716451
@diff-train-skip-merge

@pytorchbot pytorchbot requested a review from SS-JIA as a code owner October 21, 2025 20:08
Copy link

pytorch-bot bot commented Oct 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15318

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2025
@SS-JIA SS-JIA force-pushed the gh/SS-JIA/340/orig branch from 0e2bf29 to 6b50ab9 Compare October 21, 2025 21:01
Base automatically changed from gh/SS-JIA/340/orig to main October 21, 2025 21:11
…s to execute

Pull Request resolved: #15158

Title says it all! A few months back, a mechanism was introduced where an `ExecuteNode` would not call an operator's resize function if none of the arguments were updated.

However, this creates a blind spot during testing where the resize function of operators are not tested since the generated operator tests do not modify input sizes.

To address this, add a way to force the resize function to be called during testing.
ghstack-source-id: 317683546
@exported-using-ghexport

Differential Revision: [D84716451](https://our.internmc.facebook.com/intern/diff/D84716451/)
@SS-JIA SS-JIA force-pushed the gh/SS-JIA/341/orig branch from 8469c6c to 315d700 Compare October 21, 2025 21:13
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@SS-JIA SS-JIA merged commit 7f68c4f into main Oct 21, 2025
133 of 136 checks passed
@SS-JIA SS-JIA deleted the gh/SS-JIA/341/orig branch October 21, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants