Skip to content

Conversation

@jethroqti
Copy link
Contributor

Summary

Enable operators adaptive_max_pool2d and grid_sampler 2D and 3D

Test plan

python backends/qualcomm/tests/test_qnn_delegate.py TestQNNFloatingPointOperator.test_qnn_backend_adaptive_max_pool2d -b build-android -H $HOST -s $SN -m $CHIPID
python backends/qualcomm/tests/test_qnn_delegate.py TestQNNQuantizedOperator.test_qnn_backend_adaptive_max_pool2d -b build-android -H $HOST -s $SN -m $CHIPID
python backends/qualcomm/tests/test_qnn_delegate.py TestQNNFloatingPointOperator.test_qnn_backend_grid_sampler -b build-android -H $HOST -s $SN -m $CHIPID
python backends/qualcomm/tests/test_qnn_delegate.py TestQNNQuantizedOperator.test_qnn_backend_grid_sampler -b build-android -H $HOST -s $SN -m $CHIPID

@jethroqti jethroqti requested a review from cccclai as a code owner October 23, 2025 18:04
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15371

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 86bc043 with merge base 7741e70 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 23, 2025
@jethroqti
Copy link
Contributor Author

@pytorchbot label "release notes: qualcomm"

@pytorch-bot pytorch-bot bot added the release notes: qualcomm Changes to the Qualcomm backend delegate label Oct 23, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 23, 2025

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D85383242.

@cccclai
Copy link
Contributor

cccclai commented Oct 24, 2025

There are some internal errors because TypeError: TestQNNQuantizedOperatorSimulator.verify_output() got an unexpected keyword argument 'matching_criteria'. I can try forward fix

@jethroqti
Copy link
Contributor Author

There are some internal errors because TypeError: TestQNNQuantizedOperatorSimulator.verify_output() got an unexpected keyword argument 'matching_criteria'. I can try forward fix

Yes, please try to update it to see if get passes. Thanks.

…grid_sampler

Enable operators adaptive_max_pool2d and grid_sampler 2D and 3D

```bash
python backends/qualcomm/tests/test_qnn_delegate.py TestQNNFloatingPointOperator.test_qnn_backend_adaptive_max_pool2d -b build-android -H $HOST -s $SN -m $CHIPID
python backends/qualcomm/tests/test_qnn_delegate.py TestQNNQuantizedOperator.test_qnn_backend_adaptive_max_pool2d -b build-android -H $HOST -s $SN -m $CHIPID
python backends/qualcomm/tests/test_qnn_delegate.py TestQNNFloatingPointOperator.test_qnn_backend_grid_sampler -b build-android -H $HOST -s $SN -m $CHIPID
python backends/qualcomm/tests/test_qnn_delegate.py TestQNNQuantizedOperator.test_qnn_backend_grid_sampler -b build-android -H $HOST -s $SN -m $CHIPID
```
@jethroqti jethroqti force-pushed the dev1/op/gridsampler branch from 79daffe to 5acaee4 Compare November 3, 2025 16:19
@jethroqti
Copy link
Contributor Author

@pytorchbot label "release notes: qualcomm"

@jethroqti
Copy link
Contributor Author

@cccclai I made a change that the verification part is same with main branch. Let's see if pass all unit tests.

@cccclai
Copy link
Contributor

cccclai commented Nov 6, 2025

Yeah let me try

@cccclai
Copy link
Contributor

cccclai commented Nov 6, 2025

It looks all good now - thank you for the workaround

@cccclai cccclai merged commit 7771799 into pytorch:main Nov 6, 2025
146 of 147 checks passed
abhinaykukkadapu pushed a commit to abhinaykukkadapu/executorch that referenced this pull request Nov 6, 2025
…grid_sampler 2D and 3D (pytorch#15371)

### Summary
Enable operators adaptive_max_pool2d and grid_sampler 2D and 3D

### Test plan
```bash
python backends/qualcomm/tests/test_qnn_delegate.py TestQNNFloatingPointOperator.test_qnn_backend_adaptive_max_pool2d -b build-android -H $HOST -s $SN -m $CHIPID
python backends/qualcomm/tests/test_qnn_delegate.py TestQNNQuantizedOperator.test_qnn_backend_adaptive_max_pool2d -b build-android -H $HOST -s $SN -m $CHIPID
python backends/qualcomm/tests/test_qnn_delegate.py TestQNNFloatingPointOperator.test_qnn_backend_grid_sampler -b build-android -H $HOST -s $SN -m $CHIPID
python backends/qualcomm/tests/test_qnn_delegate.py TestQNNQuantizedOperator.test_qnn_backend_grid_sampler -b build-android -H $HOST -s $SN -m $CHIPID
```
@jethroqti
Copy link
Contributor Author

It looks all good now - thank you for the workaround

Great, also thanks for your efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: qualcomm Changes to the Qualcomm backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants