Skip to content

Conversation

@Camyll
Copy link

@Camyll Camyll commented Oct 28, 2025

Summary:
Apply -02 compiler flag to make FLLM autocorrect faster

Sheet measuring different scopes of applying -02 and the resulting latency
https://docs.google.com/spreadsheets/d/1ZnxoRwCIiMz3hXyhgb6sm_2UThBUyq-mpp8RzksfJMQ/edit?usp=sharing

Differential Revision: D85152814

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15425

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 10 New Failures

As of commit 8f66a03 with merge base 7741e70 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 28, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 28, 2025

@Camyll has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85152814.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary:

Apply -02 compiler flag to make FLLM autocorrect faster

Sheet measuring different scopes of applying -02 and the resulting latency
https://docs.google.com/spreadsheets/d/1ZnxoRwCIiMz3hXyhgb6sm_2UThBUyq-mpp8RzksfJMQ/edit?usp=sharing

Differential Revision: D85152814
@meta-cla
Copy link

meta-cla bot commented Nov 4, 2025

Hi @Camyll!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

# Add -O2 compiler flag when the compiler_flag_O2 config is set
kwargs["compiler_flags"] = kwargs["compiler_flags"] + select({
"DEFAULT": [],
"fbsource//xplat/assistant/oacr/native/scripts:compiler_flag_O2": ["-O2"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmn, not seeing this be commented out. It should look like the examples on line 102-112, or this: #15582

chandanjain999 added a commit to chandanjain999/executorch that referenced this pull request Nov 4, 2025
Summary:

Apply -02 compiler flag to make FLLM autocorrect faster

Sheet measuring different scopes of applying -02 and the resulting latency
https://docs.google.com/spreadsheets/d/1ZnxoRwCIiMz3hXyhgb6sm_2UThBUyq-mpp8RzksfJMQ/edit?usp=sharing

****Latency****

Reviewed By: BlakeLucchesi

Differential Revision: D85152814
@lucylq
Copy link
Contributor

lucylq commented Nov 4, 2025

Closing as duplicate of #15583

@lucylq lucylq closed this Nov 4, 2025
meta-codesync bot pushed a commit that referenced this pull request Nov 5, 2025
Differential Revision: D85152814

Pull Request resolved: #15583
abhinaykukkadapu pushed a commit to abhinaykukkadapu/executorch that referenced this pull request Nov 6, 2025
Differential Revision: D85152814

Pull Request resolved: pytorch#15583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants