Fix regression with 8 bit quant mat mul. #15445
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15445
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 524fd7d with merge base c0df044 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@trivedivivek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85767668. |
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 29, 2025
Summary: This diff fixes a regression in the 8-bit quantized matrix multiplication operation, by reducing number of columns processed to 1 instead of 2 as before. Differential Revision: D85767668
trivedivivek
added
the
release notes: vulkan
trivedivivek
force-pushed
the
export-D85767668
branch
from
5e69357 to
7a70cdd
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 30, 2025
Summary: This diff fixes a regression in the 8-bit quantized matrix multiplication operation, by reducing number of columns processed to 1 instead of 2 as before. Differential Revision: D85767668
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 30, 2025
Summary: This diff fixes a regression in the 8-bit quantized matrix multiplication operation, by reducing number of columns processed to 1 instead of 2 as before. Differential Revision: D85767668
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 30, 2025
Summary: This diff fixes a regression in the 8-bit quantized matrix multiplication operation, by reducing number of columns processed to 1 instead of 2 as before. Differential Revision: D85767668
trivedivivek
force-pushed
the
export-D85767668
branch
2 times, most recently
from
4cac3f9 to
63ab796
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 30, 2025
Summary: This diff fixes a regression in the 8-bit quantized matrix multiplication operation, by reducing number of columns processed to 1 instead of 2 as before. Differential Revision: D85767668
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 30, 2025
Summary: This diff fixes a regression in the 8-bit quantized matrix multiplication operation, by reducing number of columns processed to 1 instead of 2 as before. Differential Revision: D85767668
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 30, 2025
Summary: This diff fixes a regression in the 8-bit quantized matrix multiplication operation, by reducing number of columns processed to 1 instead of 2 as before. Differential Revision: D85767668
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 30, 2025
Summary: This diff fixes a regression in the 8-bit quantized matrix multiplication operation, by reducing number of columns processed to 1 instead of 2 as before. Differential Revision: D85767668
SS-JIA
approved these changes
Oct 30, 2025
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 30, 2025
Summary: This diff fixes a regression in the 8-bit quantized matrix multiplication operation, by reducing number of columns processed to 1 instead of 2 as before. Reviewed By: SS-JIA Differential Revision: D85767668
trivedivivek
force-pushed
the
export-D85767668
branch
from
63ab796 to
01905db
Compare
Summary: This diff fixes a regression in the 8-bit quantized matrix multiplication operation, by reducing number of columns processed to 1 instead of 2 as before. Reviewed By: SS-JIA Differential Revision: D85767668
trivedivivek
force-pushed
the
export-D85767668
branch
from
01905db to
524fd7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff fixes a regression in the 8-bit quantized matrix multiplication operation, by reducing number of columns processed to 1 instead of 2 as before.
Differential Revision: D85767668