Skip to content

Address compiler switch errors/warnings (ExecuteTorch) #15543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2025
Merged

Address compiler switch errors/warnings (ExecuteTorch) #15543

merged 1 commit into from
Nov 4, 2025

Conversation

@NSProgrammer
Copy link
Contributor

@NSProgrammer NSProgrammer commented Nov 4, 2025

Summary: Make improvements so that it is safe to use the -Wswitch-enum compiler error in a project consuming RN

Differential Revision: D86070193

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15543

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 11 Pending

As of commit c75c14a with merge base 9c568d7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 4, 2025

@NSProgrammer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86070193.

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

NSProgrammer added a commit to NSProgrammer/executorch that referenced this pull request Nov 4, 2025
@NSProgrammer @facebook-github-bot
Address compiler switch errors/warnings (ExecuteTorch) (pytorch#15543)
4be321d 
Summary:

Make improvements so that it is safe to use the `-Wswitch-enum` compiler error in a project consuming RN

Reviewed By: shoumikhin

Differential Revision: D86070193
NSProgrammer added a commit to NSProgrammer/executorch that referenced this pull request Nov 4, 2025
@NSProgrammer @facebook-github-bot
Address compiler switch errors/warnings (ExecuteTorch) (pytorch#15543)
7b15517 
Summary:

Make improvements so that it is safe to use the `-Wswitch-enum` compiler error in a project consuming RN

Reviewed By: shoumikhin

Differential Revision: D86070193
NSProgrammer added a commit to NSProgrammer/executorch that referenced this pull request Nov 4, 2025
@NSProgrammer @facebook-github-bot
Address compiler switch errors/warnings (ExecuteTorch) (pytorch#15543)
a30237e 
Summary:

Make improvements so that it is safe to use the `-Wswitch-enum` compiler error in a project consuming RN

Reviewed By: shoumikhin

Differential Revision: D86070193
@NSProgrammer @facebook-github-bot
Address compiler switch errors/warnings (ExecuteTorch) (pytorch#15543)
c75c14a 
Summary:

Make improvements so that it is safe to use the `-Wswitch-enum` compiler error in a project consuming RN

Reviewed By: shoumikhin

Differential Revision: D86070193
meta-codesync bot pushed a commit to facebookresearch/ocean that referenced this pull request Nov 4, 2025
@NSProgrammer @meta-codesync
Fix -Wswitch-enum errors
8a23409 
Summary:
X-link: pytorch/executorch#15543

Make improvements so that it is safe to use the `-Wswitch-enum` compiler error in a project consuming RN

Reviewed By: abashyam

Differential Revision: D86219351

fbshipit-source-id: 01183cef4a81b168eb8bfab1b8cdd02a752f8938
@meta-codesync meta-codesync bot merged commit 1fcba99 into pytorch:main Nov 4, 2025
44 of 45 checks passed
abhinaykukkadapu pushed a commit to abhinaykukkadapu/executorch that referenced this pull request Nov 6, 2025
@NSProgrammer @abhinaykukkadapu
Address compiler switch errors/warnings (ExecuteTorch)
b68bb31 
Differential Revision: D86070193

Pull Request resolved: pytorch#15543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shoumikhin shoumikhin shoumikhin approved these changes

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NSProgrammer @shoumikhin