Skip to content

Arm backend: Add docstrings for operator_support/minmax_support.py #15555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2025
Merged

Arm backend: Add docstrings for operator_support/minmax_support.py #15555

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a43b48
Arm backend: Add docstrings for operator_support/minmax_support.py
Sebastian-Larsson Sep 10, 2025
141d18c
Merge branch 'main' into minimax_docs
zingo Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion backends/arm/operator_support/minmax_support.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
#
# This source code is licensed under the BSD-style license found in the
# LICENSE file in the root directory of this source tree.
"""Declare operator support for min/max along a dimension in TOSA.

Provide support checks ensuring that argmax/argmin indices are not consumed,
restricting to float profiles until index quantization is supported.

"""

import torch.fx as fx
from executorch.backends.arm.operator_support.tosa_supported_operators import (
Expand All @@ -14,6 +20,8 @@

@register_tosa_support_check
class MinMaxSupported(SupportedTOSAOperatorCheck):
"""Provide TOSA support check for ``aten.max.dim`` and ``aten.min.dim``."""

targets = [
exir_ops.edge.aten.max.dim,
exir_ops.edge.aten.min.dim,
Expand All @@ -24,7 +32,16 @@ class MinMaxSupported(SupportedTOSAOperatorCheck):
TosaSpecification.create_from_string("TOSA-1.0+FP"),
]

def is_node_tosa_supported(self, node: fx.Node, tosa_spec: TosaSpecification):
def is_node_tosa_supported(
self, node: fx.Node, tosa_spec: TosaSpecification
) -> bool:
"""Return True if the node is supported by TOSA.

Allow max/min when the argmax/argmin output is unused or dropped (i.e.,
only the value is consumed). Disallow cases where arg indices are
further used.

"""
if node.target in [exir_ops.edge.aten.max.dim, exir_ops.edge.aten.min.dim]:
no_argmax = len(node.users) == 1
no_argmax_users = (len(node.users) == 2) and (
Expand Down
Loading