-
Notifications
You must be signed in to change notification settings - Fork 722
Enable fast path for negative indices #15622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Differential Revision: D86351194
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15622
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 Pending, 5 Unrelated FailuresAs of commit 7d7d1d6 with merge base 6b545a2 ( NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@manuelcandales has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86351194. |
This PR needs a
|
|
@pytorchbot cherry-pick --onto release/1.0 -c critical |
Fast path was broken for negative indices (see #15285) Because of this, #15366 disabled the fast path when the index tensor had negative indices. In this PR we fix the bug, and re-enable the fast path for negative indices. Fixes #15285 Differential Revision: D86351194 (cherry picked from commit 2fa44ea)
Cherry picking #15622The cherry pick PR is at #15657 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Fast path was broken for negative indices (see pytorch#15285) Because of this, pytorch#15366 disabled the fast path when the index tensor had negative indices. In this PR we fix the bug, and re-enable the fast path for negative indices. Fixes pytorch#15285 Differential Revision: D86351194
Fast path was broken for negative indices (see #15285)
Because of this, #15366 disabled the fast path when the index tensor had negative indices.
In this PR we fix the bug, and re-enable the fast path for negative indices.
Fixes #15285
Differential Revision: D86351194