-
Notifications
You must be signed in to change notification settings - Fork 720
[ET-VK][ez] Constrain out repsets individually #15704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Address the TODO comment in the `tag_memory_meta_pass.py` graph pass.
```
# TODO(ssjia): For most ops, inputs and outputs must be synchronized, so there
# is no need to constrain output repsets explicitly. Currently, the exceptions
# (i.e. choose qparams) already define constrined repsets for the output, so
# there is again no need to explicitly constrain the outputs. If an operator
# appears later on that does not sync input and output representations, and
# defines ambiguous repsets for the output tensor(s), then we will need to add
# additional logic to this function to constrain the output repsets separately
# from the input repsets.
```
This condition is now fulfilled with the below diff.
Differential Revision: [D86674164](https://our.internmc.facebook.com/intern/diff/D86674164/)
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15704
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 916f046 with merge base aba44fd ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Address the TODO comment in the `tag_memory_meta_pass.py` graph pass.
```
# TODO(ssjia): For most ops, inputs and outputs must be synchronized, so there
# is no need to constrain output repsets explicitly. Currently, the exceptions
# (i.e. choose qparams) already define constrined repsets for the output, so
# there is again no need to explicitly constrain the outputs. If an operator
# appears later on that does not sync input and output representations, and
# defines ambiguous repsets for the output tensor(s), then we will need to add
# additional logic to this function to constrain the output repsets separately
# from the input repsets.
```
This condition is now fulfilled with the below diff.
Differential Revision: [D86674164](https://our.internmc.facebook.com/intern/diff/D86674164/)
[ghstack-poisoned]
4dde949
into
gh/SS-JIA/362/base
Stack from ghstack (oldest at bottom):
Address the TODO comment in the
tag_memory_meta_pass.pygraph pass.This condition is now fulfilled with the below diff.
Differential Revision: D86674164