Skip to content

Conversation

@SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Nov 10, 2025

Stack from ghstack (oldest at bottom):

Address the TODO comment in the tag_memory_meta_pass.py graph pass.

        # TODO(ssjia): For most ops, inputs and outputs must be synchronized, so there
        # is no need to constrain output repsets explicitly. Currently, the exceptions
        # (i.e. choose qparams) already define constrined repsets for the output, so
        # there is again no need to explicitly constrain the outputs. If an operator
        # appears later on that does not sync input and output representations, and
        # defines ambiguous repsets for the output tensor(s), then we will need to add
        # additional logic to this function to constrain the output repsets separately
        # from the input repsets.

This condition is now fulfilled with the below diff.

Differential Revision: D86674164

Address the TODO comment in the `tag_memory_meta_pass.py` graph pass.

```
        # TODO(ssjia): For most ops, inputs and outputs must be synchronized, so there
        # is no need to constrain output repsets explicitly. Currently, the exceptions
        # (i.e. choose qparams) already define constrined repsets for the output, so
        # there is again no need to explicitly constrain the outputs. If an operator
        # appears later on that does not sync input and output representations, and
        # defines ambiguous repsets for the output tensor(s), then we will need to add
        # additional logic to this function to constrain the output repsets separately
        # from the input repsets.
```

This condition is now fulfilled with the below diff.

Differential Revision: [D86674164](https://our.internmc.facebook.com/intern/diff/D86674164/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15704

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit 916f046 with merge base aba44fd (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Address the TODO comment in the `tag_memory_meta_pass.py` graph pass.

```
        # TODO(ssjia): For most ops, inputs and outputs must be synchronized, so there
        # is no need to constrain output repsets explicitly. Currently, the exceptions
        # (i.e. choose qparams) already define constrined repsets for the output, so
        # there is again no need to explicitly constrain the outputs. If an operator
        # appears later on that does not sync input and output representations, and
        # defines ambiguous repsets for the output tensor(s), then we will need to add
        # additional logic to this function to constrain the output repsets separately
        # from the input repsets.
```

This condition is now fulfilled with the below diff.

Differential Revision: [D86674164](https://our.internmc.facebook.com/intern/diff/D86674164/)

[ghstack-poisoned]
@meta-codesync meta-codesync bot merged commit 4dde949 into gh/SS-JIA/362/base Nov 11, 2025
163 of 169 checks passed
@meta-codesync meta-codesync bot deleted the gh/SS-JIA/362/head branch November 11, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants