Skip to content

[ET-VK] Add int and bool tensor support for many operators #15834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/1.0
Choose a base branch
from
Open

[ET-VK] Add int and bool tensor support for many operators #15834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions backends/vulkan/runtime/graph/ops/glsl/clone.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,7 @@ clone:
DTYPE:
- VALUE: half
- VALUE: float
- VALUE: int32
- VALUE: uint8
shader_variants:
- NAME: clone
1 change: 1 addition & 0 deletions backends/vulkan/runtime/graph/ops/glsl/concat_buffer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ concat_buffer:
DTYPE:
- VALUE: half
- VALUE: float
- VALUE: int32
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to concat_texture.yaml, this operator only adds int32 support but not uint8. For consistency with other operators in this PR that add both dtypes, consider adding uint8 support here as well.

Suggested change
- VALUE: int32
- VALUE: int32
- VALUE: uint8

Copilot uses AI. Check for mistakes.
shader_variants:
- NAME: concat_1_buffer
NUM_INPUTS: 1
Expand Down
4 changes: 0 additions & 4 deletions backends/vulkan/runtime/graph/ops/glsl/concat_texture.glsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@ void main() {

VEC4_T out_texel = imageLoad(t_out, out_pos);

VEC4_T test_texel = VEC4_T(-1.0);

for (int comp = 0; comp < 4; ++comp) {
ivec4 out_tidx = out_read_start_tidx;
out_tidx[out_packed_dim] += comp;
Expand All @@ -124,7 +122,6 @@ void main() {
// of the previous input batch; if so, then don't overwrite this texel
// element
if (out_tidx[concat_dim] < concat_offset) {
test_texel[comp] = -5.0;
continue;
}

Expand Down Expand Up @@ -164,7 +161,6 @@ void main() {
inp${i}_packed_dim);

out_texel[comp] = texelFetch(t_inp${i}, in_posi.xyz, 0)[in_posi.w];
test_texel[comp] = out_texel[comp];
continue;
}
else {
Expand Down
1 change: 1 addition & 0 deletions backends/vulkan/runtime/graph/ops/glsl/concat_texture.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ concat_texture:
DTYPE:
- VALUE: half
- VALUE: float
- VALUE: int32
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The concat_texture operator only adds int32 support but not uint8, while most other operators in this PR (e.g., repeat_interleave, repeat_channel, pad_height_width, pad_channel, clone) add both int32 and uint8 support. The GLSL shader code for concat operations appears to be generic and should support uint8. Consider adding uint8 support for consistency.

Suggested change
- VALUE: int32
- VALUE: int32
- VALUE: uint8

Copilot uses AI. Check for mistakes.
shader_variants:
- NAME: concat_1_texture3d
NUM_INPUTS: 1
Expand Down
1 change: 1 addition & 0 deletions backends/vulkan/runtime/graph/ops/glsl/expand_buffer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@ expand_buffer:
- VALUE: half
- VALUE: float
- VALUE: int32
- VALUE: uint8
shader_variants:
- NAME: expand_buffer
1 change: 1 addition & 0 deletions backends/vulkan/runtime/graph/ops/glsl/full.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@ full:
- VALUE: half
- VALUE: float
- VALUE: int32
- VALUE: uint8
shader_variants:
- NAME: full
1 change: 1 addition & 0 deletions backends/vulkan/runtime/graph/ops/glsl/index_select.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ index_select:
- VALUE: half
- VALUE: float
- VALUE: int32
- VALUE: uint8
shader_variants:
- NAME: index_select
1 change: 1 addition & 0 deletions backends/vulkan/runtime/graph/ops/glsl/index_select_channel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ index_select_channel:
- VALUE: half
- VALUE: float
- VALUE: int32
- VALUE: uint8
shader_variants:
- NAME: index_select_channel
2 changes: 2 additions & 0 deletions backends/vulkan/runtime/graph/ops/glsl/pad_channel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,7 @@ pad_channel:
DTYPE:
- VALUE: float
- VALUE: half
- VALUE: int32
- VALUE: uint8
shader_variants:
- NAME: pad_channel
2 changes: 2 additions & 0 deletions backends/vulkan/runtime/graph/ops/glsl/pad_height_width.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,7 @@ pad_height_width:
DTYPE:
- VALUE: float
- VALUE: half
- VALUE: int32
- VALUE: uint8
shader_variants:
- NAME: pad_height_width
2 changes: 2 additions & 0 deletions backends/vulkan/runtime/graph/ops/glsl/repeat_channel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,7 @@ repeat_channel:
DTYPE:
- VALUE: half
- VALUE: float
- VALUE: int32
- VALUE: uint8
shader_variants:
- NAME: repeat_channel
2 changes: 2 additions & 0 deletions backends/vulkan/runtime/graph/ops/glsl/repeat_interleave.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,7 @@ repeat_interleave:
DTYPE:
- VALUE: half
- VALUE: float
- VALUE: int32
- VALUE: uint8
shader_variants:
- NAME: repeat_interleave
Loading