Skip to content

Conversation

@martinlsm
Copy link
Collaborator

@martinlsm martinlsm commented Nov 19, 2025

  • Add *Pass suffix for passes missing it
  • Add missing _pass suffixes to python files containing passes
  • Correct pass name: DecomposeLinearVectorNormPass to DecomposeLinalgVectorNormPass
  • Rename ConvertIntPowToMuls to DecomposeIntPowPass
  • Rename QuantizeOperatorArguments to QuantizeClampArgumentsPass

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

* Add *Pass suffix for passes missing it
* Add missing _pass suffixes to python files containing passes
* Correct pass name: DecomposeLinearVectorNormPass to
  DecomposeLinalgVectorNormPass
* Rename ConvertIntPowToMuls to DecomposeIntPowPass
* Rename QuantizeOperatorArguments to QuantizeClampArgumentsPass

Signed-off-by: Martin Lindström <Martin.Lindstroem@arm.com>
Change-Id: Ied2bdce1a5240464db25a0b42eb9cee8a078f73b
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15888

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit 89fd30a with merge base 9952aef (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 19, 2025
@martinlsm
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@martinlsm
Copy link
Collaborator Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Nov 19, 2025
@zingo zingo added the release notes: none Do not include this in the release notes label Nov 19, 2025
@zingo
Copy link
Collaborator

zingo commented Nov 19, 2025

Hi @metascroy this one does a lot of renaming, hopefully safe but if you feel it should be tested inside Meta fell free to :)

@metascroy
Copy link
Contributor

Hi @metascroy this one does a lot of renaming, hopefully safe but if you feel it should be tested inside Meta fell free to :)

Importing now for testing: D87451263

@meta-codesync
Copy link

meta-codesync bot commented Nov 19, 2025

@metascroy has imported this pull request. If you are a Meta employee, you can view this in D87451263.

@metascroy
Copy link
Contributor

Internal tests pass on this, so we're good to merge

@metascroy metascroy self-requested a review November 19, 2025 23:25
@zingo zingo merged commit 6e9fb80 into pytorch:main Nov 20, 2025
305 of 312 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants