-
Notifications
You must be signed in to change notification settings - Fork 737
Arm backend: Rename passes for consistency #15888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Add *Pass suffix for passes missing it * Add missing _pass suffixes to python files containing passes * Correct pass name: DecomposeLinearVectorNormPass to DecomposeLinalgVectorNormPass * Rename ConvertIntPowToMuls to DecomposeIntPowPass * Rename QuantizeOperatorArguments to QuantizeClampArgumentsPass Signed-off-by: Martin Lindström <Martin.Lindstroem@arm.com> Change-Id: Ied2bdce1a5240464db25a0b42eb9cee8a078f73b
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15888
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 89fd30a with merge base 9952aef ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label ciflow/trunk |
|
@pytorchbot label "partner: arm" |
|
Hi @metascroy this one does a lot of renaming, hopefully safe but if you feel it should be tested inside Meta fell free to :) |
Importing now for testing: D87451263 |
|
@metascroy has imported this pull request. If you are a Meta employee, you can view this in D87451263. |
|
Internal tests pass on this, so we're good to merge |
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai