Skip to content

[Executorch][llama] Split main in lib + binary #15919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gh/kimishpatel/215/base
Choose a base branch
from
Open

[Executorch][llama] Split main in lib + binary #15919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions examples/models/llama/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ DEFINE_int32(

DEFINE_bool(warmup, false, "Whether to run a warmup run.");

std::vector<std::string> parseStringList(const std::string& input);

// Helper function to parse comma-separated string lists
std::vector<std::string> parseStringList(const std::string& input) {
std::vector<std::string> result;
Expand Down
12 changes: 10 additions & 2 deletions examples/models/llama/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ def define_common_targets():
if not runtime.is_oss or not aten:
aten_suffix = "_aten" if aten else ""

runtime.cxx_binary(
name = "main" + aten_suffix,
runtime.cxx_library(
name = "main" + aten_suffix + "_lib",
Copy link
Contributor

@lucylq lucylq Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "main_lib" + aten_suffix

Copy link
Contributor Author

@kimishpatel kimishpatel Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

srcs = [
"main.cpp",
],
Expand All @@ -25,3 +25,11 @@ def define_common_targets():
],
**get_oss_build_kwargs()
)

runtime.cxx_binary(
name = "main" + aten_suffix,
srcs = [],
deps = [
":main" + aten_suffix + "_lib",
Copy link
Contributor

@lucylq lucylq Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, ":main_lib" + aten_suffix,

],
)
Loading