Skip to content

Conversation

@lucylq
Copy link
Contributor

@lucylq lucylq commented Nov 20, 2025

Summary:

  1. Use ExecutorchBackendConfig instead of inserting the pass.
  2. Move SpecPropPass after user-defined passes. It was originally swapped here: D80840528. cc ethansfng, who has a pass that should run before SpecPropPass

Differential Revision: D87576772

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15932

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 20, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 20, 2025

@lucylq has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87576772.

@meta-codesync
Copy link

meta-codesync bot commented Nov 20, 2025

@lucylq has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87576772.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

@JacobSzwejbka JacobSzwejbka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Nov 21, 2025
Summary:

1. Use `ExecutorchBackendConfig` instead of inserting the pass.
2. Move SpecPropPass after user-defined passes. It was originally swapped here: D80840528. cc ethansfng, who has a pass that should run before SpecPropPass

Reviewed By: JacobSzwejbka, larryliu0820

Differential Revision: D87576772
Summary:

1. Use `ExecutorchBackendConfig` instead of inserting the pass.
2. Move SpecPropPass after user-defined passes. It was originally swapped here: D80840528. cc ethansfng, who has a pass that should run before SpecPropPass

Reviewed By: JacobSzwejbka, larryliu0820

Differential Revision: D87576772
@meta-codesync meta-codesync bot merged commit 350ea3c into pytorch:main Nov 22, 2025
142 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants