Skip to content

Fix MobileBert timeout CI failures #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Fix MobileBert timeout CI failures #1729

wants to merge 11 commits into from

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Jan 26, 2024 •
edited
Loading

I'm making the timeout value configurable for each models and defaults to 90m (the current value). The timeout value for MobileBert can then be increased to 120m 180m. The model is running only trunk anyway, so there is no impact on PR duration. A better fix would be to figure out why it's running slowly, but I leave it to the experts.

I'm trying to get lint and pull signals all green before landing #1697 (although they are not that related).

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 26, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1729

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 658f5fc with merge base 394e15b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 26, 2024
@huydhn huydhn changed the title Fix MobileBert and llama2 CI failures Fix MobileBert timeout CI failures Jan 27, 2024
@huydhn huydhn mentioned this pull request Jan 27, 2024
Closed
@huydhn huydhn marked this pull request as ready for review January 27, 2024 00:33
@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

huydhn
huydhn commented Jan 27, 2024
View reviewed changes
.github/workflows/doc-build.yml
submodules: 'true'
repository: pytorch/executorch
upload-artifact: docs
timeout: 90
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to MobileBert, but this timeout hasn't been set yet, so doc jobs timeout sometimes after 30m, i.e. https://github.com/pytorch/executorch/actions/runs/7663108516/job/20885389022?pr=1658. Setting it to 90m like the rest of CI jobs.

@huydhn huydhn marked this pull request as draft January 27, 2024 04:13
@huydhn huydhn marked this pull request as ready for review February 2, 2024 04:18
@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@huydhn merged this pull request in 340c69b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirklandsign kirklandsign Awaiting requested review from kirklandsign

@mergennachin mergennachin Awaiting requested review from mergennachin

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@huydhn @facebook-github-bot