Skip to content

Fix flatcc + pybindings linking on linux #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix flatcc + pybindings linking on linux #2467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,6 @@ if(EXECUTORCH_BUILD_PYBIND)
etdump
executorch
extension_data_loader
flatcc
portable_ops_lib
util
torch
Expand Down
9 changes: 7 additions & 2 deletions sdk/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@ endforeach()
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/../third-party/flatcc
${CMAKE_BINARY_DIR}/third-party/flatcc)

# Fix for "relocation R_X86_64_32 against `.rodata' can not be used when making
# a shared object; recompile with -fPIC" when building on some x86 linux
# systems.
set_property(TARGET flatccrt PROPERTY POSITION_INDEPENDENT_CODE ON)

# Assume we are cross-compiling and the CMAKE_TOOLCHAIN_FILE is set
include(ExternalProject)

Expand Down Expand Up @@ -118,7 +123,7 @@ add_library(etdump ${CMAKE_CURRENT_SOURCE_DIR}/etdump/etdump_flatcc.cpp

target_link_libraries(
etdump
PUBLIC etdump_schema flatcc
PUBLIC etdump_schema flatccrt
PRIVATE executorch)

add_custom_command(
Expand Down Expand Up @@ -148,7 +153,7 @@ target_include_directories(

# Install libraries
install(
TARGETS bundled_program etdump flatcc
TARGETS bundled_program etdump flatccrt
DESTINATION ${CMAKE_BINARY_DIR}/lib
INCLUDES
DESTINATION ${_common_include_directories})