Skip to content

Add Llava model to examples #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 21 commits into from
Closed

Add Llava model to examples #2576

wants to merge 21 commits into from

Conversation

@iseeyuan
Copy link
Contributor

@iseeyuan iseeyuan commented Mar 21, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Add Llava model to examples
dc5db81 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2576

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit afde0c3 with merge base db7c057 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

iseeyuan pushed a commit that referenced this pull request Mar 21, 2024
Add Llava model to examples
1939832 
ghstack-source-id: 227be82
Pull Request resolved: #2576
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 21, 2024
iseeyuan pushed a commit that referenced this pull request Mar 22, 2024
Add Llava model to examples
8c4d0f8 
ghstack-source-id: 3c843d3
Pull Request resolved: #2576
@iseeyuan iseeyuan changed the base branch from gh/iseeyuan/6/base to main March 22, 2024 23:14
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 22, 2024

@iseeyuan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@iseeyuan iseeyuan changed the base branch from main to gh/iseeyuan/6/base March 25, 2024 16:05
iseeyuan pushed a commit that referenced this pull request Mar 25, 2024
Add Llava model to examples
832628e 
ghstack-source-id: e3ff469
Pull Request resolved: #2576
@iseeyuan iseeyuan changed the base branch from gh/iseeyuan/6/base to main March 25, 2024 16:15
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 25, 2024

@iseeyuan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@iseeyuan iseeyuan changed the base branch from main to gh/iseeyuan/6/base March 27, 2024 13:58
iseeyuan pushed a commit that referenced this pull request Mar 27, 2024
Add Llava model to examples
e44c02c 
ghstack-source-id: 1624ec8
Pull Request resolved: #2576
@iseeyuan iseeyuan changed the base branch from gh/iseeyuan/6/base to main March 27, 2024 14:13
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 27, 2024

@iseeyuan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@iseeyuan iseeyuan changed the base branch from main to gh/iseeyuan/6/base March 28, 2024 00:16
iseeyuan pushed a commit that referenced this pull request Mar 28, 2024
Add Llava model to examples
1d7ca1f 
ghstack-source-id: 4b4e328
Pull Request resolved: #2576
huydhn
huydhn reviewed Mar 28, 2024
View reviewed changes
.ci/scripts/gather_test_models.py
"w2l": "linux.12xlarge",
"ic4": "linux.12xlarge",
"resnet50": "linux.12xlarge",
"llava_encoder": "linux.4xlarge",
Copy link
Contributor

@huydhn huydhn Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To run this on PR, please look for model_should_run_on_event and add llava_encoder to the list there. This is the list of models we want to cover on PR, the rest are only run in trunk after committing (to save some CI resources a while ago)

iseeyuan pushed a commit that referenced this pull request Mar 29, 2024
Add Llava model to examples
9bd3ccf 
ghstack-source-id: 804a1d0
Pull Request resolved: #2576
iseeyuan pushed a commit that referenced this pull request Mar 29, 2024
Add Llava model to examples
3eccd0e 
ghstack-source-id: 698cf5f
Pull Request resolved: #2576
@iseeyuan iseeyuan changed the base branch from gh/iseeyuan/6/base to main March 29, 2024 23:58
@iseeyuan iseeyuan changed the base branch from main to gh/iseeyuan/6/base March 29, 2024 23:59
iseeyuan pushed a commit that referenced this pull request Mar 30, 2024
Add Llava model to examples
b6c472b 
ghstack-source-id: 65e3223
Pull Request resolved: #2576
@iseeyuan iseeyuan changed the base branch from gh/iseeyuan/6/base to main March 30, 2024 00:45
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 30, 2024

@iseeyuan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

2 similar comments
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 30, 2024

@iseeyuan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 30, 2024

@iseeyuan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@iseeyuan iseeyuan changed the base branch from main to gh/iseeyuan/6/base March 31, 2024 00:19
iseeyuan pushed a commit that referenced this pull request Mar 31, 2024
Add Llava model to examples
eaee046 
ghstack-source-id: 2b0267d
Pull Request resolved: #2576
@iseeyuan iseeyuan changed the base branch from gh/iseeyuan/6/base to main March 31, 2024 00:21
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 31, 2024

@iseeyuan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@iseeyuan iseeyuan changed the base branch from main to gh/iseeyuan/6/base March 31, 2024 01:44
iseeyuan pushed a commit that referenced this pull request Mar 31, 2024
Add Llava model to examples
16a9a15 
ghstack-source-id: e894202
Pull Request resolved: #2576
@iseeyuan iseeyuan changed the base branch from gh/iseeyuan/6/base to main March 31, 2024 01:44
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 31, 2024

@iseeyuan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 31, 2024

@iseeyuan merged this pull request in e283967.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn left review comments

@cccclai cccclai cccclai approved these changes

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iseeyuan @facebook-github-bot @huydhn @cccclai