Skip to content

Conversation

@tarun292
Copy link
Contributor

@tarun292 tarun292 commented Apr 1, 2024

Summary: Refactoring the core logic of select_copy into a helper utility function so that it can be utilized by other operators that internally need to do a select operation.

Differential Revision: D55565485

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 1, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2784

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7ebf1e1 with merge base 3e2e26d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 1, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55565485

facebook-github-bot pushed a commit that referenced this pull request Apr 1, 2024
Summary:

Refactoring the core logic of select_copy into a helper utility function so that it can be utilized by other operators that internally need to do a select operation.

Differential Revision: D55565485
Summary:

Refactoring the core logic of select_copy into a helper utility function so that it can be utilized by other operators that internally need to do a select operation.

Differential Revision: D55565485
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55565485

facebook-github-bot pushed a commit that referenced this pull request Apr 1, 2024
Summary:

Refactoring the core logic of select_copy into a helper utility function so that it can be utilized by other operators that internally need to do a select operation.

Differential Revision: D55565485
tarun292 added a commit that referenced this pull request Apr 1, 2024
Summary:

Refactoring the core logic of select_copy into a helper utility function so that it can be utilized by other operators that internally need to do a select operation.

Differential Revision: D55565485
facebook-github-bot pushed a commit that referenced this pull request Apr 1, 2024
Summary:

Refactoring the core logic of select_copy into a helper utility function so that it can be utilized by other operators that internally need to do a select operation.

Differential Revision: D55565485
Copy link
Contributor

@iseeyuan iseeyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in fd1a338.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants