Add sort util for 1D tensors #2786
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2786
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit e52a09f with merge base 554eebe ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55577025 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 1, 2024
Summary: This diff adds a simple sort utility that sorts a tensor's values and returns the sorted values and the sorted indices in the out tensors that are provided. There are currently two limitations to this sort: - It only supports 1D tensors currently, has to be extended to support 2D and greater tensors. - Input types are assumed to be float and it currently asserts on that. This has to be templatized to support all dtypes. Differential Revision: D55577025
iseeyuan
reviewed
Apr 1, 2024
| using torch::executor::ArrayRef; | ||
| using torch::executor::testing::TensorFactory; | ||
|
|
||
| TEST(SortUtilTest, SortTensorTest) { |
iseeyuan
approved these changes
Apr 1, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 1, 2024
Summary: This diff adds a simple sort utility that sorts a tensor's values and returns the sorted values and the sorted indices in the out tensors that are provided. There are currently two limitations to this sort: - It only supports 1D tensors currently, has to be extended to support 2D and greater tensors. - Input types are assumed to be float and it currently asserts on that. This has to be templatized to support all dtypes. Reviewed By: iseeyuan Differential Revision: D55577025
facebook-github-bot
force-pushed
the
export-D55577025
branch
from
5dc444d to
cbd825c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55577025 |
tarun292
added a commit
that referenced
this pull request
Apr 1, 2024
Summary: This diff adds a simple sort utility that sorts a tensor's values and returns the sorted values and the sorted indices in the out tensors that are provided. There are currently two limitations to this sort: - It only supports 1D tensors currently, has to be extended to support 2D and greater tensors. - Input types are assumed to be float and it currently asserts on that. This has to be templatized to support all dtypes. Reviewed By: iseeyuan Differential Revision: D55577025
tarun292
added a commit
that referenced
this pull request
Apr 1, 2024
Summary: This diff adds a simple sort utility that sorts a tensor's values and returns the sorted values and the sorted indices in the out tensors that are provided. There are currently two limitations to this sort: - It only supports 1D tensors currently, has to be extended to support 2D and greater tensors. - Input types are assumed to be float and it currently asserts on that. This has to be templatized to support all dtypes. Reviewed By: iseeyuan Differential Revision: D55577025
tarun292
force-pushed
the
export-D55577025
branch
from
cbd825c to
b57570b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55577025 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
Summary: This diff adds a simple sort utility that sorts a tensor's values and returns the sorted values and the sorted indices in the out tensors that are provided. There are currently two limitations to this sort: - It only supports 1D tensors currently, has to be extended to support 2D and greater tensors. - Input types are assumed to be float and it currently asserts on that. This has to be templatized to support all dtypes. Reviewed By: iseeyuan Differential Revision: D55577025
facebook-github-bot
force-pushed
the
export-D55577025
branch
from
b57570b to
b31cdbf
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55577025 |
tarun292
added a commit
that referenced
this pull request
Apr 2, 2024
Summary: This diff adds a simple sort utility that sorts a tensor's values and returns the sorted values and the sorted indices in the out tensors that are provided. There are currently two limitations to this sort: - It only supports 1D tensors currently, has to be extended to support 2D and greater tensors. - Input types are assumed to be float and it currently asserts on that. This has to be templatized to support all dtypes. Reviewed By: iseeyuan Differential Revision: D55577025
tarun292
force-pushed
the
export-D55577025
branch
from
b31cdbf to
a38b3ff
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55577025 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
Summary: This diff adds a simple sort utility that sorts a tensor's values and returns the sorted values and the sorted indices in the out tensors that are provided. There are currently two limitations to this sort: - It only supports 1D tensors currently, has to be extended to support 2D and greater tensors. - Input types are assumed to be float and it currently asserts on that. This has to be templatized to support all dtypes. Reviewed By: iseeyuan Differential Revision: D55577025
facebook-github-bot
force-pushed
the
export-D55577025
branch
from
a38b3ff to
99e56f3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55577025 |
tarun292
added a commit
that referenced
this pull request
Oct 8, 2024
Summary: Pull Request resolved: #2786 This diff adds a simple sort utility that sorts a tensor's values and returns the sorted values and the sorted indices in the out tensors that are provided. There are currently two limitations to this sort: - It only supports 1D tensors currently, has to be extended to support 2D and greater tensors. - Input types are assumed to be float and it currently asserts on that. This has to be templatized to support all dtypes. Reviewed By: iseeyuan Differential Revision: D55577025
tarun292
force-pushed
the
export-D55577025
branch
from
99e56f3 to
bf0616b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55577025 |
Differential Revision: D64072692
Summary: Pull Request resolved: #2786 This diff adds a simple sort utility that sorts a tensor's values and returns the sorted values and the sorted indices in the out tensors that are provided. There are currently two limitations to this sort: - It only supports 1D tensors currently, has to be extended to support 2D and greater tensors. - Input types are assumed to be float and it currently asserts on that. This has to be templatized to support all dtypes. Reviewed By: iseeyuan Differential Revision: D55577025
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55577025 |
tarun292
force-pushed
the
export-D55577025
branch
from
bf0616b to
e52a09f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds a simple sort utility that sorts a tensor's values and returns the sorted values and the sorted indices in the out tensors that are provided.
There are currently two limitations to this sort:
Differential Revision: D55577025