Introduce preprocess custom ops #4548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4548
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 598e34f with merge base 92edd04 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60491675 |
|
This pull request was exported from Phabricator. Differential Revision: D60491675 |
lucylq
force-pushed
the
export-D60491675
branch
from
67e886d to
6b3c7e7
Compare
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Aug 6, 2024
Summary: Pull Request resolved: pytorch#4548 For preprocess, we have two custom ops, pad and reshape. These are used to hide the implementation and any data dependent issues from export, allowing us to export the model. The model definition is in D60051533, though we're trying to upstream it to torchtune: meta-pytorch/torchtune#1242 This diff adds: - Python impl + tests - C++ function signatures + buck setup Differential Revision: D60491675
|
This pull request was exported from Phabricator. Differential Revision: D60491675 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Aug 6, 2024
Summary: Pull Request resolved: pytorch#4548 For preprocess, we have two custom ops, pad and reshape. These are used to hide the implementation and any data dependent issues from export, allowing us to export the model. The model definition is in D60051533, though we're trying to upstream it to torchtune: meta-pytorch/torchtune#1242 This diff adds: - Python impl + tests - C++ function signatures + buck setup Differential Revision: D60491675
lucylq
force-pushed
the
export-D60491675
branch
from
6b3c7e7 to
ef69514
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60491675 |
lucylq
force-pushed
the
export-D60491675
branch
from
ef69514 to
f722f21
Compare
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Aug 7, 2024
Summary: Pull Request resolved: pytorch#4548 For preprocess, we have two custom ops, pad and reshape. These are used to hide the implementation and any data dependent issues from export, allowing us to export the model. The model definition is in D60051533, though we're trying to upstream it to torchtune: meta-pytorch/torchtune#1242 This diff adds: - Python impl + tests - C++ function signatures + buck setup for reshape. Differential Revision: D60491675
|
This pull request was exported from Phabricator. Differential Revision: D60491675 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Aug 7, 2024
Summary: Pull Request resolved: pytorch#4548 For preprocess, we have two custom ops, pad and reshape. These are used to hide the implementation and any data dependent issues from export, allowing us to export the model. The model definition is in D60051533, though we're trying to upstream it to torchtune: meta-pytorch/torchtune#1242 This diff adds: - Python impl + tests - C++ function signatures + buck setup for reshape. Differential Revision: D60491675
lucylq
force-pushed
the
export-D60491675
branch
from
f722f21 to
b6fdf55
Compare
Summary: Pull Request resolved: pytorch#4548 For preprocess, we have two custom ops, pad and reshape. These are used to hide the implementation and any data dependent issues from export, allowing us to export the model. The model definition is in D60051533, though we're trying to upstream it to torchtune: meta-pytorch/torchtune#1269 This diff adds: - Python impl + tests - C++ function signatures + buck setup for reshape using [EXECUTORCH_LIBRARY](https://pytorch.org/executorch/stable/kernel-library-custom-aten-kernel.html#custom-ops-c-api) Differential Revision: D60491675
|
This pull request was exported from Phabricator. Differential Revision: D60491675 |
lucylq
force-pushed
the
export-D60491675
branch
from
b6fdf55 to
598e34f
Compare
larryliu0820
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For preprocess, we have two custom ops, pad and reshape.
These are used to hide the implementation and any data dependent issues from export, allowing us to export the model.
The model definition is in D60051533, though we're trying to upstream it to torchtune: meta-pytorch/torchtune#1242
This diff adds:
Differential Revision: D60491675