Skip to content

Fix MacOS build #5042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Fix MacOS build #5042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc9b5b2
Fix MacOS build
kirklandsign Sep 3, 2024
cd019b5
Use executorch_no_prim_ops
kirklandsign Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion extension/llm/custom_ops/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ if(EXECUTORCH_BUILD_KERNELS_CUSTOM_AOT)
target_link_libraries(custom_ops_aot_lib PUBLIC executorch_no_prim_ops)
endif()

target_link_libraries(custom_ops_aot_lib PUBLIC cpublas torch)
target_link_libraries(
custom_ops_aot_lib PUBLIC cpublas torch extension_threadpool
)
if(WIN32)
# There is no direct replacement for libpthread.so on Windows. For the
# Windows build, link directly against pthreadpool and cpuinfo.
Expand Down
4 changes: 3 additions & 1 deletion extension/threadpool/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ if(NOT CMAKE_CXX_STANDARD)
endif()

add_library(extension_threadpool threadpool.cpp threadpool_guard.cpp cpuinfo_utils.cpp)
target_link_libraries(extension_threadpool PUBLIC executorch cpuinfo pthreadpool)
target_link_libraries(
extension_threadpool PUBLIC executorch_no_prim_ops cpuinfo pthreadpool
)
target_include_directories(extension_threadpool PUBLIC ${EXECUTORCH_ROOT}/..)
target_include_directories(
extension_threadpool
Expand Down
Loading