Clean up devtools/etdump #5180
Merged
Clean up devtools/etdump #5180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5180
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8fa3af6 with merge base 6b1e328 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62394222 |
tarun292
approved these changes
Sep 9, 2024
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Sep 9, 2024
Summary: Pull Request resolved: pytorch#5180 Move to the new namespace scheme. While I was here: - Hide internal types - Remove unused functions - Change names to follow the style guide - Give the generated flatbuffer code a less-general namespace that won't conflict with `executorch::etdump::` - Copy over the most recent version of `scalar_type.fbs` Reviewed By: tarun292 Differential Revision: D62394222
dbort
force-pushed
the
export-D62394222
branch
from
e6382ac to
e66a73d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62394222 |
Summary: Pull Request resolved: pytorch#5180 Move to the new namespace scheme. While I was here: - Hide internal types - Remove unused functions - Change names to follow the style guide - Give the generated flatbuffer code a less-general namespace that won't conflict with `executorch::etdump::` - Copy over the most recent version of `scalar_type.fbs` Reviewed By: tarun292 Differential Revision: D62394222
|
This pull request was exported from Phabricator. Differential Revision: D62394222 |
dbort
force-pushed
the
export-D62394222
branch
from
e66a73d to
8fa3af6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Move to the new namespace scheme.
While I was here:
executorch::etdump::scalar_type.fbsReviewed By: tarun292
Differential Revision: D62394222