Skip to content

Conversation

kirklandsign
Copy link
Contributor

No description provided.

kirklandsign and others added 26 commits August 31, 2024 00:25
Instead, in Java layer, add a note that if no args is given to forward, we will infer that the user wants to try with sample value
Instead, if we pass no args to forward(), we infer that the user wants to test against default inputs (ones) so we prepare the inputs for user
Copy link

pytorch-bot bot commented Sep 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5205

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d85a621 with merge base 4ce0f9d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2024
@kirklandsign kirklandsign changed the base branch from main to experiments-jni September 9, 2024 22:33
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm working on the JSON content in benchmark results atm, and will update the TODO parts assigned to me in the benchmark activity here

Copy link
Contributor

@guangy10 guangy10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter error, otherwise lgtm

Base automatically changed from experiments-jni to main September 10, 2024 18:42
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit e245590 into main Sep 10, 2024
41 checks passed
@facebook-github-bot facebook-github-bot deleted the app-side-change branch September 10, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants