-
Notifications
You must be signed in to change notification settings - Fork 690
App side change #5205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App side change #5205
Conversation
Instead, in Java layer, add a note that if no args is given to forward, we will infer that the user wants to try with sample value
Instead, if we pass no args to forward(), we infer that the user wants to test against default inputs (ones) so we prepare the inputs for user
…into experiments-jni
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5205
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d85a621 with merge base 4ce0f9d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm working on the JSON content in benchmark results atm, and will update the TODO parts assigned to me in the benchmark activity here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linter error, otherwise lgtm
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
No description provided.