Skip to content

Conversation

@zonglinpeng
Copy link
Contributor

Summary:
Recently change in cadence added new internal dependencies which caused confusion in building the hifi binaries. Added detailed intrustiones in a sample bash script to build with xtensa toolchain.

Also based on internal development, added instructions to setup cmake/pip on internal developement servers.

Reviewed By: hsharma35

Differential Revision: D62768143

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5398

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit c124b47 with merge base 92adb94 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 16, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62768143

- HiFi Audio
- ...

## Setup (Internal Only)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we put this in OSS at all?

Copy link
Contributor Author

@zonglinpeng zonglinpeng Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentatively yes, because it's the instruction for cadence oss but exposes nothing extra

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe I'm reading this wrong, we have an internal link and the arvr and nfs paths there... that's all internal right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Just rethought I will remove these lines

zonglinpeng added a commit to zonglinpeng/executorch that referenced this pull request Sep 16, 2024
…orch#5398)

Summary:

Recently change in cadence added new internal dependencies which caused confusion in building the hifi binaries. Added detailed intrustiones in a sample bash script to build with xtensa toolchain.

Also based on internal development, added instructions to setup cmake/pip on internal developement servers.

Reviewed By: hsharma35

Differential Revision: D62768143
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62768143

…orch#5398)

Summary:

Recently change in cadence added new internal dependencies which caused confusion in building the hifi binaries. Added detailed intrustiones in a sample bash script to build with xtensa toolchain.

Also based on internal development, added instructions to setup cmake/pip on internal developement servers.

Reviewed By: hsharma35

Differential Revision: D62768143
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62768143

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 5a3eceb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants