Move etensor types to their new namespace #5773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 30, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5773
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1b68687 with merge base eecf74f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Summary: Pull Request resolved: #5569 Move these types out of the old `torch::executor` namespace. Put them in their own namespace so that no-one will see them by default, unlike their old location in `torch::executor`. Most users should not use these directly, instead using the `executorch::aten` aliases. These ETensor types live under `executorch::runtime...` to make it a little more clear that they're semi-internal. Also: - Hide bfloat16's `bits_from_f32`, which was only used by tests - Hide the `min` implementation used by string_view. Although it was in an anonymous namespace, it was in a header, so it was visible to all code in `torch::executor`. - Remove an unnecessary forward declaration from BlasKernel.h which conflicted with the new namespace Reviewed By: swolchok Differential Revision: D63294217 fbshipit-source-id: 5241fd5a0b487631b6460222b6c3e27e82aea5f0 (cherry picked from commit 6ff52cc)
dbort
force-pushed
the
cherry-pick-5569-by-pytorch_bot_bot_
branch
from
68a55b0 to
1b68687
Compare
|
Rebased on top of #5772 which is a required dep |
dbort
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Move these types out of the old
torch::executornamespace. Put them in their own namespace so that no-one will see them by default, unlike their old location intorch::executor.Most users should not use these directly, instead using the
executorch::atenaliases. These ETensor types live underexecutorch::runtime...to make it a little more clear that they're semi-internal.Also:
bits_from_f32, which was only used by testsminimplementation used by string_view. Although it was in an anonymous namespace, it was in a header, so it was visible to all code intorch::executor.Differential Revision: D63294217