Add CastInt64ToInt32Pass #5842
Closed
Add CastInt64ToInt32Pass #5842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integer placeholders, for example in this examples x = torch.Tensor([1.]) + 1 Are by default lowered as int64 tensors. As int64 is not a valid TOSA dtype, we cast these tensors to int32. Reference: https://www.mlplatform.org/tosa/tosa_spec.html#_supported_number_formats Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: Ice59625b7fd68ff3a544ee4648fe05f69b9333e6
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5842
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 6b95253 with merge base 20a157f ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Erik-Lundell
added
partner: arm
facebook-github-bot
added
the
CLA Signed
Contributor
|
CI issues? |
Collaborator
Contributor
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
Can't tell why the arm-backend job is failing, seems like infra issue, because FVP returned 0. Let me rerun it. |
Contributor
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@digantdesai merged this pull request in 28c9548. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integer placeholders, for example in this examples x = torch.Tensor([1.]) + 1
Are by default lowered as int64 tensors.
As int64 is not a valid TOSA dtype, we cast these
tensors to int32.
Reference:
https://www.mlplatform.org/tosa/tosa_spec.html#_supported_number_formats
Change-Id: Ice59625b7fd68ff3a544ee4648fe05f69b9333e6