Improve the qcomm aot part docs #5868
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5868
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8e56591 with merge base e194feb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63878765 |
shewu-quic
approved these changes
Oct 7, 2024
| cp -f backends/qualcomm/PyQnnWrapperAdaptor.cpython-310-x86_64-linux-gnu.so $EXECUTORCH_ROOT/backends/qualcomm/python | ||
|
|
||
| # Workaround for fbs files in exir/_serialize | ||
| cp schema/program.fbs exir/_serialize/program.fbs |
There was a problem hiding this comment.
Because base dir is build-x86 here.
I think that it could add $EXECUTORCH_ROOT here.
cp $EXECUTORCH_ROOT/schema/program.fbs $EXECUTORCH_ROOT/exir/_serialize/program.fbs
cp $EXECUTORCH_ROOT/schema/scalar_type.fbs $EXECUTORCH_ROOT/exir/_serialize/scalar_type.fbs
backends/qualcomm/scripts/build.sh
Outdated
|
|
||
| rm -f $PRJ_ROOT/backends/qualcomm/python/* | ||
| cp -fv $BUILD_ROOT/backends/qualcomm/Py* "$PRJ_ROOT/backends/qualcomm/python" | ||
| cp "$PRJ_ROOT/schema/program.fbs" "$PRJ_ROOT/exir/_serialize/program.fbs" |
chiwwang
reviewed
Oct 7, 2024
There was a problem hiding this comment.
I need to delegate to @haowhsu-quic , @shewu-quic . Please help. Thanks!
haowhsu-quic
approved these changes
Oct 7, 2024
Summary: the schema file copy is an actual AOT step. It's a workaround but it has been here a while, probably easier to have it as part of the build script instead of manually doing it everytime Differential Revision: D63878765
cccclai
force-pushed
the
export-D63878765
branch
from
6a06f1a to
8e56591
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63878765 |
kirklandsign
approved these changes
Oct 7, 2024
|
This pull request has been merged in 478a9b6. |
|
@pytorchbot cherry-pick --onto release/0.4 -c docs |
pytorchbot
pushed a commit
that referenced
this pull request
Oct 7, 2024
Summary: Pull Request resolved: #5868 the schema file copy is an actual AOT step. It's a workaround but it has been here a while, probably easier to have it as part of the build script instead of manually doing it everytime Reviewed By: kirklandsign Differential Revision: D63878765 fbshipit-source-id: 7fc4b848b72e2859364e21cbea3dd1b433d6cd8e (cherry picked from commit 478a9b6)
Cherry picking #5868The cherry pick PR is at #5939 The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
jackzhxng
pushed a commit
that referenced
this pull request
Oct 7, 2024
Improve the qcomm aot part docs (#5868) Summary: Pull Request resolved: #5868 the schema file copy is an actual AOT step. It's a workaround but it has been here a while, probably easier to have it as part of the build script instead of manually doing it everytime Reviewed By: kirklandsign Differential Revision: D63878765 fbshipit-source-id: 7fc4b848b72e2859364e21cbea3dd1b433d6cd8e (cherry picked from commit 478a9b6) Co-authored-by: Chen Lai <chenlai@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: the schema file copy is an actual AOT step. It's a workaround but it has been here a while, probably easier to have it as part of the build script instead of manually doing it everytime
Differential Revision: D63878765