Cleanup export_model API calls #5882
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5882
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6b560c1 with merge base 84f5a56 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63795843 |
facebook-github-bot
force-pushed
the
export-D63795843
branch
from
ebd030c to
718b0c8
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
Summary: Lots of things are redundant and a few need to move to utils. Subsequent changes will split the export function and separate the run part. Main changes: - call `fuse_pt2` after `convert_pt2` instead of `quantize_pt2`, and avoid calling `convert_pt2` twice - move `print_ops_info` into `export_to_cadence` - remove the need to call `export_to_edge` in `export_model` - move the serialization utils to `utils.py` Differential Revision: D63795843
|
This pull request was exported from Phabricator. Differential Revision: D63795843 |
zonglinpeng
approved these changes
Oct 4, 2024
Summary: Lots of things are redundant and a few need to move to utils. Subsequent changes will split the export function and separate the run part. Main changes: - call `fuse_pt2` after `convert_pt2` instead of `quantize_pt2`, and avoid calling `convert_pt2` twice - move `print_ops_info` into `export_to_cadence` - remove the need to call `export_to_edge` in `export_model` - move the serialization utils to `utils.py` Reviewed By: zonglinpeng Differential Revision: D63795843
mcremon-meta
force-pushed
the
export-D63795843
branch
from
718b0c8 to
6b560c1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63795843 |
|
This pull request has been merged in 8fc3e20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Lots of things are redundant and a few need to move to utils. Subsequent changes will split the export function and separate the run part.
Main changes:
fuse_pt2afterconvert_pt2instead ofquantize_pt2, and avoid callingconvert_pt2twiceprint_ops_infointoexport_to_cadenceexport_to_edgeinexport_modelutils.pyDifferential Revision: D63795843