Skip to content

Conversation

@haowhsu-quic
Copy link
Collaborator

Summary

  • enable wav2letter e2e example

Summary
- enable wav2letter e2e example
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 7, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5924

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9aceb17 with merge base 8fc3e20 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 7, 2024
@haowhsu-quic
Copy link
Collaborator Author

Hi @cccclai, please have a look on this, thank you.
I wonder if we could land #5543? It will be helpful for us to continue enabling more oss models.

@cccclai
Copy link
Contributor

cccclai commented Oct 7, 2024

Hi @cccclai, please have a look on this, thank you. I wonder if we could land #5543? It will be helpful for us to continue enabling more oss models.

Yes for sure. Sorry for getting late on this, and thank you for enabling more models!

@guangy10
Copy link
Contributor

guangy10 commented Oct 7, 2024

When this model is enabled can you please update the CI to cover this model?

  1. Update the test script: https://github.com/pytorch/executorch/blob/main/.ci/scripts/test_model.sh#L147
  2. Update the nightly benchmark workflow to see the perf: https://github.com/pytorch/executorch/blob/main/.github/workflows/android-perf.yml#L87

@haowhsu-quic
Copy link
Collaborator Author

Hi @guangy10, this model requires pretrained_weight as an input argument which requires getting checkpoint in advance.
I think the downloading process and extra argument may change the script logic now. Do you have suggestions?

@cccclai
Copy link
Contributor

cccclai commented Oct 16, 2024

If there are extra efforts to add them to CI, maybe we can have a follow up on that. Thoughts? @guangy10

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit 7895982 into pytorch:main Nov 11, 2024
41 checks passed
@haowhsu-quic haowhsu-quic deleted the dev_w2l branch February 7, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants