-
Notifications
You must be signed in to change notification settings - Fork 700
Update docs on Module new APIs. #5952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5952
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit be1eb15 with merge base f005dd5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D64005568 |
docs/source/extension-module.md
Outdated
|
|
||
| #### Setting Outputs | ||
|
|
||
| Currently, only tensor outputs are supported for setting, and they must not be memory-planned at model export time. Memory-planned tensors are preallocated during model export and cannot be replaced. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be more clear:
"Only outputs of type Tensor can be set at runtime, and ..."
When I first read the current version I interpreted it as "Only outputs of tensors" (which doesn't really mean anything) rather than "only outputs that are tensors".
Summary: Pull Request resolved: #5952 Reviewed By: kirklandsign Differential Revision: D64005568
|
This pull request was exported from Phabricator. Differential Revision: D64005568 |
|
@pytorchbot cherry-pick --onto release/0.4 -c docs |
|
This pull request has been merged in 0424eef. |
|
@pytorchbot cherry-pick --onto release/0.4 -c docs |
Cherry picking #5952The cherry pick PR is at #5968 The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Differential Revision: D64005568