Skip to content

Conversation

@shoumikhin
Copy link
Contributor

Differential Revision: D64005568

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 7, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5952

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit be1eb15 with merge base f005dd5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 7, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64005568


#### Setting Outputs

Currently, only tensor outputs are supported for setting, and they must not be memory-planned at model export time. Memory-planned tensors are preallocated during model export and cannot be replaced.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be more clear:

"Only outputs of type Tensor can be set at runtime, and ..."

When I first read the current version I interpreted it as "Only outputs of tensors" (which doesn't really mean anything) rather than "only outputs that are tensors".

Summary: Pull Request resolved: #5952

Reviewed By: kirklandsign

Differential Revision: D64005568
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64005568

@shoumikhin
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.4 -c docs

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 0424eef.

@shoumikhin
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.4 -c docs

pytorchbot pushed a commit that referenced this pull request Oct 8, 2024
Summary: Pull Request resolved: #5952

Reviewed By: kirklandsign

Differential Revision: D64005568

fbshipit-source-id: 7cd8ab9fe33d5745064aca7720d34ce1d9f4f06b
(cherry picked from commit 0424eef)
@pytorchbot
Copy link
Collaborator

Cherry picking #5952

The cherry pick PR is at #5968 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

jackzhxng pushed a commit that referenced this pull request Oct 8, 2024
Update docs on Module new APIs. (#5952)

Summary: Pull Request resolved: #5952

Reviewed By: kirklandsign

Differential Revision: D64005568

fbshipit-source-id: 7cd8ab9fe33d5745064aca7720d34ce1d9f4f06b
(cherry picked from commit 0424eef)

Co-authored-by: Anthony Shoumikhin <shoumikhin@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants