[10/n][ET-VK] Introduce create_image_from_ahb utility
#5992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now include handle to `VkDevice` in `VulkanImage` since our allocations don't go through VMA. **Internal:** Following image creation of `myvulkanahb`. https://www.internalfb.com/code/aosp-vendor-meta-tools-camera-tools/[wrist-sw5100-14.0%3Af8460689765eee9332f461491a1edcfc6ad8fb92]/myvulkanahb/myvulkanahb.cpp?lines=22%2C94-96 https://www.internalfb.com/code/aosp-vendor-meta-tools-camera-tools/[wrist-sw5100-14.0%3Af8460689765eee9332f461491a1edcfc6ad8fb92]/myvulkanahb/vulkan/ImageProcessorAhbRgbaInRgbaOut.cpp?lines=26-36%2C40-47 Differential Revision: [D63298759](https://our.internmc.facebook.com/intern/diff/D63298759/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5992
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8701ab5 with merge base e540bcb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63298759 |
This was referenced Oct 8, 2024
We now include handle to `VkDevice` in `VulkanImage` since our allocations don't go through VMA. **Internal:** Following image creation of `myvulkanahb`. https://www.internalfb.com/code/aosp-vendor-meta-tools-camera-tools/[wrist-sw5100-14.0%3Af8460689765eee9332f461491a1edcfc6ad8fb92]/myvulkanahb/myvulkanahb.cpp?lines=22%2C94-96 https://www.internalfb.com/code/aosp-vendor-meta-tools-camera-tools/[wrist-sw5100-14.0%3Af8460689765eee9332f461491a1edcfc6ad8fb92]/myvulkanahb/vulkan/ImageProcessorAhbRgbaInRgbaOut.cpp?lines=26-36%2C40-47 Differential Revision: [D63298759](https://our.internmc.facebook.com/intern/diff/D63298759/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D63298759 |
We now include handle to `VkDevice` in `VulkanImage` since our allocations don't go through VMA. Differential Revision: [D63298759](https://our.internmc.facebook.com/intern/diff/D63298759/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D63298759 |
junpi3
pushed a commit
that referenced
this pull request
Oct 8, 2024
Pull Request resolved: #5992 We now include handle to `VkDevice` in `VulkanImage` since our allocations don't go through VMA. **Internal:** Following image creation of `myvulkanahb`. https://www.internalfb.com/code/aosp-vendor-meta-tools-camera-tools/[wrist-sw5100-14.0%3Af8460689765eee9332f461491a1edcfc6ad8fb92]/myvulkanahb/myvulkanahb.cpp?lines=22%2C94-96 https://www.internalfb.com/code/aosp-vendor-meta-tools-camera-tools/[wrist-sw5100-14.0%3Af8460689765eee9332f461491a1edcfc6ad8fb92]/myvulkanahb/vulkan/ImageProcessorAhbRgbaInRgbaOut.cpp?lines=26-36%2C40-47 ghstack-source-id: 246903715 @exported-using-ghexport Differential Revision: [D63298759](https://our.internmc.facebook.com/intern/diff/D63298759/)
We now include handle to `VkDevice` in `VulkanImage` since our allocations don't go through VMA. Differential Revision: [D63298759](https://our.internmc.facebook.com/intern/diff/D63298759/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D63298759 |
We now include handle to `VkDevice` in `VulkanImage` since our allocations don't go through VMA. Differential Revision: [D63298759](https://our.internmc.facebook.com/intern/diff/D63298759/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D63298759 |
We now include handle to `VkDevice` in `VulkanImage` since our allocations don't go through VMA. Differential Revision: [D63298759](https://our.internmc.facebook.com/intern/diff/D63298759/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D63298759 |
SS-JIA
approved these changes
Oct 9, 2024
We now include handle to `VkDevice` in `VulkanImage` since our allocations don't go through VMA. Differential Revision: [D63298759](https://our.internmc.facebook.com/intern/diff/D63298759/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D63298759 |
junpi3
pushed a commit
that referenced
this pull request
Oct 9, 2024
Pull Request resolved: #5992 We now include handle to `VkDevice` in `VulkanImage` since our allocations don't go through VMA. **Internal:** Following image creation of `myvulkanahb`. https://www.internalfb.com/code/aosp-vendor-meta-tools-camera-tools/[wrist-sw5100-14.0%3Af8460689765eee9332f461491a1edcfc6ad8fb92]/myvulkanahb/myvulkanahb.cpp?lines=22%2C94-96 https://www.internalfb.com/code/aosp-vendor-meta-tools-camera-tools/[wrist-sw5100-14.0%3Af8460689765eee9332f461491a1edcfc6ad8fb92]/myvulkanahb/vulkan/ImageProcessorAhbRgbaInRgbaOut.cpp?lines=26-36%2C40-47 ghstack-source-id: 247129375 @exported-using-ghexport Differential Revision: [D63298759](https://our.internmc.facebook.com/intern/diff/D63298759/)
We now include handle to `VkDevice` in `VulkanImage` since our allocations don't go through VMA. Differential Revision: [D63298759](https://our.internmc.facebook.com/intern/diff/D63298759/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D63298759 |
|
This pull request has been merged in 991f0a9. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#5992 We now include handle to `VkDevice` in `VulkanImage` since our allocations don't go through VMA. **Internal:** Following image creation of `myvulkanahb`. https://www.internalfb.com/code/aosp-vendor-meta-tools-camera-tools/[wrist-sw5100-14.0%3Af8460689765eee9332f461491a1edcfc6ad8fb92]/myvulkanahb/myvulkanahb.cpp?lines=22%2C94-96 https://www.internalfb.com/code/aosp-vendor-meta-tools-camera-tools/[wrist-sw5100-14.0%3Af8460689765eee9332f461491a1edcfc6ad8fb92]/myvulkanahb/vulkan/ImageProcessorAhbRgbaInRgbaOut.cpp?lines=26-36%2C40-47 ghstack-source-id: 247129375 @exported-using-ghexport Differential Revision: [D63298759](https://our.internmc.facebook.com/intern/diff/D63298759/)
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#5992 We now include handle to `VkDevice` in `VulkanImage` since our allocations don't go through VMA. **Internal:** Following image creation of `myvulkanahb`. https://www.internalfb.com/code/aosp-vendor-meta-tools-camera-tools/[wrist-sw5100-14.0%3Af8460689765eee9332f461491a1edcfc6ad8fb92]/myvulkanahb/myvulkanahb.cpp?lines=22%2C94-96 https://www.internalfb.com/code/aosp-vendor-meta-tools-camera-tools/[wrist-sw5100-14.0%3Af8460689765eee9332f461491a1edcfc6ad8fb92]/myvulkanahb/vulkan/ImageProcessorAhbRgbaInRgbaOut.cpp?lines=26-36%2C40-47 ghstack-source-id: 244302584 @exported-using-ghexport Differential Revision: [D63298759](https://our.internmc.facebook.com/intern/diff/D63298759/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
VkUtils.hinapi.h#6066create_image_from_ahbutility #5992We now include handle to
VkDeviceinVulkanImagesince our allocations don't go through VMA.Differential Revision: D63298759