Skip to content

Conversation

pytorchbot
Copy link
Collaborator

Summary: Fixed some Error() call sites and added better checking on the method name

Reviewed By: larryliu0820

Differential Revision: D63547425

closes #5648

Copy link

pytorch-bot bot commented Oct 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6108

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 78990e9 with merge base eecf74f (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 10, 2024
Copy link
Contributor

@jackzhxng jackzhxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems safe but need to fix tests

@larryliu0820 larryliu0820 mentioned this pull request Oct 11, 2024
Summary:
Pull Request resolved: #5726

Fixed some Error() call sites and added better checking on the method name

Reviewed By: larryliu0820, dbort

Differential Revision: D63547425

fbshipit-source-id: 69e32f90cbc2607b75df5186b0289fe385ce95e3
(cherry picked from commit 9720715)
@dbort dbort force-pushed the cherry-pick-5726-by-pytorch_bot_bot_ branch from 41b1230 to 78990e9 Compare October 11, 2024 16:50
@dbort
Copy link
Contributor

dbort commented Oct 11, 2024

The bulk of this was squashed into cherrypick #6151. Rebased on top of that to show the differences, which aren't critical for the release branch. Closing this commit without merging.

@dbort dbort closed this Oct 11, 2024
@dbort dbort deleted the cherry-pick-5726-by-pytorch_bot_bot_ branch October 11, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants