Align aot_arm_compiler to latest export flow #6327
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
robell
commented
Oct 17, 2024
robell
commented
- Update to_edge_transform_and_lower rather than export_to_edge
- fix channel last on some models
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6327
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 8e0412b with merge base 6b858f2 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
robell
force-pushed
the
aot_export_update
branch
from
3027be6 to
891d73a
Compare
- Update to_edge_transform_and_lower rather than export_to_edge - fix channel last on some models Signed-off-by: Rob Elliott <Robert.Elliott@arm.com> Change-Id: I0f8e9206aa1ff3004a746955010c7bf01c896347
robell
force-pushed
the
aot_export_update
branch
from
891d73a to
8e0412b
Compare
zingo
added
partner: arm
digantdesai
approved these changes
Oct 17, 2024
Contributor
digantdesai
left a comment
digantdesai
left a comment
There was a problem hiding this comment.
LGTM. Left a nit. Stamping
| # Wrap quantized model back into an exported_program | ||
| exported_program = torch.export.export_for_training(model, example_inputs) | ||
|
|
||
| if args.delegate: |
Contributor
There was a problem hiding this comment.
refactor this as
my_partitioner = this or []
edge = to_edge_transoform_and_lower(..., partitioner=my_partitioner)
Contributor
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@digantdesai merged this pull request in 1e9ebdf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.