[pybind] Add back extension suffix for portable lib shared object in pip wheel #6363
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Summary: Initially our portable lib prebuilt library is named as:
Where it includes an
EXT_SUFFIXcpython-310-x86_64-linux-gnuconsists of architecture and build OS information.This is enforced by
setuptoolsfollowing PEP 3149 and there's no good way to change this behavior.#5961 was an attempt to rename the .so filename at packaging stage to
_portable_lib.so, so that it is easier to be found byfind_package()macro in CMake.However #5961 is breaking the other prebuilt libraries such as
libcustom_ops_aot_lib.sowhich depends on the original_portable_lib.cpython-310-x86_64-linux-gnu.soname in its RPATH.This PR is a fix that reverts #5961 and restore the full name during packaging, but try to match the
EXT_SUFFIXin CMake to be able to find the .so file.Test Plan:
Does not throw
_portable_lib.cpython-310-x86_64-linux-gnu.sonot found error.Reviewers:
Subscribers:
Tasks:
Tags: