Skip to content

another commit #6380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

another commit #6380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a521b5
Update
kirklandsign Oct 21, 2024
0f5f6d8
Update
kirklandsign Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/scripts/propose_ghstack_orig_pr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ def create_prs_for_orig_branch(pr_stack: List[int], repo: Repository):
for i in range(len(pr_stack)):
pr = repo.get_pull(pr_stack[i])
if not pr.is_merged():
# add some comment
pass
# Check for invariant: For the current PR, it must be gh/user/x/base <- gh/user/x/head
assert pr.base.ref.replace("base", "head") == pr.head.ref
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/ghstack_land.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
name: Propose to merge ghstack orig PRs to main
on:
pull_request:
types: [open, synchronize, closed]
branches:
- 'gh/cccclai/[0-9]+/base'
- 'gh/dbort/[0-9]+/base'
Expand Down
Loading