Skip to content

[Android] Strip .so for Release build #6441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

[Android] Strip .so for Release build #6441

merged 1 commit into from
Oct 22, 2024

Conversation

kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented Oct 22, 2024 •
edited
Loading

If the user wants to use unstripped .so for debugging, use debug build by

export EXECUTORCH_CMAKE_BUILD_TYPE=Debug
sh build/build_android_llm_demo.sh

Stack from ghstack (oldest at bottom):

@kirklandsign
Update
f8b7835 
[ghstack-poisoned]
@kirklandsign kirklandsign mentioned this pull request Oct 22, 2024
Merged
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 22, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6441

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f8b7835 with merge base ca47839 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kirklandsign added a commit that referenced this pull request Oct 22, 2024
@kirklandsign
[Android] Strip .so for Release build
9975186 
ghstack-source-id: bd8ae69
Pull Request resolved: #6441
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 22, 2024
@kirklandsign kirklandsign merged commit 84ee4a3 into gh/kirklandsign/14/base Oct 22, 2024
46 checks passed
@kirklandsign kirklandsign deleted the gh/kirklandsign/14/head branch October 22, 2024 22:34
@pytorchbot pytorchbot mentioned this pull request Oct 22, 2024
Merged
kirklandsign added a commit that referenced this pull request Oct 22, 2024
@pytorchbot @kirklandsign
[Android] Strip .so for Release build (#6443)
66c57db 
ghstack-source-id: bd8ae69
Pull Request resolved: #6441

---------

Co-authored-by: Hansong Zhang <hsz@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cccclai cccclai cccclai approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kirklandsign @cccclai @facebook-github-bot