Skip to content

Conversation

@trivedivivek
Copy link
Contributor

@trivedivivek trivedivivek commented Oct 23, 2024

Stack from ghstack (oldest at bottom):

This diff makes changes to the q linear op in the Vulkan backend of Executorch.
The changes includes reducing the precision of all int storage to reduce register usage and improve performance.
The diff also replaces some big persistent texture coordinate storage variables with smaller variables to further improve performance.

Differential Revision: D64780578

… reducing some texture coordinate storage variables to improve performance.

This diff makes changes to the q linear op in the Vulkan backend of Executorch.
The changes includes reducing the precision of all int storage to reduce register usage and improve performance.
The diff also replaces some big persistent texture coordinate storage variables with smaller variables to further improve performance.

Differential Revision: [D64780578](https://our.internmc.facebook.com/intern/diff/D64780578/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 23, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6465

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 160b83d with merge base fa30e80 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 23, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64780578

@facebook-github-bot facebook-github-bot merged commit e77b89e into gh/trivedivivek/5/base Oct 31, 2024
46 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/trivedivivek/5/head branch October 31, 2024 15:06
kirklandsign added a commit that referenced this pull request Oct 31, 2024
… reducing some texture coordinate storage variables to improve performance. (#6595)

This diff makes changes to the q linear op in the Vulkan backend of Executorch.
The changes includes reducing the precision of all int storage to reduce register usage and improve performance.
The diff also replaces some big persistent texture coordinate storage variables with smaller variables to further improve performance.

Differential Revision: [D64780578](https://our.internmc.facebook.com/intern/diff/D64780578/)

ghstack-source-id: 249679441
Pull Request resolved: #6465

Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
… reducing some texture coordinate storage variables to improve performance.

This diff makes changes to the q linear op in the Vulkan backend of Executorch.
The changes includes reducing the precision of all int storage to reduce register usage and improve performance.
The diff also replaces some big persistent texture coordinate storage variables with smaller variables to further improve performance.

Differential Revision: [D64780578](https://our.internmc.facebook.com/intern/diff/D64780578/)

ghstack-source-id: 249679441
Pull Request resolved: pytorch/executorch#6465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants