Skip to content

Add cat/stack ops to generic annotator #6494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2024
Merged

Add cat/stack ops to generic annotator #6494

merged 3 commits into from
Nov 6, 2024

Conversation

@SaoirseARM
Copy link
Collaborator

  • Adds capability to annotator ops with more than one input i.e cat/stack
  • Adds some missing data layout ops to generic_annotator
  • Removes Quantize_io from tests which are covered by generic annotator
  • Removes duplicates from is_share_obs_or_fq_op

@SaoirseARM
Add cat/stack ops to generic annotator
c4d5892 
- Adds capability to annotator ops with more than one input
- Adds some missing data layout ops to generic_annotator
- Removes Quantize_io from tests which are covered by generic annotator
- Removes duplicates from is_share_obs_or_fq_op
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 25, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6494

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6f873c4 with merge base c045c35 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 25, 2024
@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label 'partner: arm'

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Oct 25, 2024
@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@digantdesai
Copy link
Contributor

Found issues internally, can you please fix it? 🙏

executorch/backends/arm/quantizer/quantization_annotation/generic_annotator.py:83:18 Incompatible parameter type [6]: In call `_annotate_input_qspec_map`, for 2nd positional argument, expected `Node` but got `Union[List[Node], Node]`.

executorch/backends/arm/quantizer/quantization_annotation/generic_annotator.py:85:58 Incompatible parameter type [6]: In call `torch.ao.quantization.quantizer.quantizer.SharedQuantizationSpec.__init__`, for 1st positional argument, expected `Union[Tuple[Node, Node], Node]` but got `Tuple[Union[List[Node], Node], typing.Any]`.

@SaoirseARM
Copy link
Collaborator Author

Found issues internally, can you please fix it? 🙏

executorch/backends/arm/quantizer/quantization_annotation/generic_annotator.py:83:18 Incompatible parameter type [6]: In call `_annotate_input_qspec_map`, for 2nd positional argument, expected `Node` but got `Union[List[Node], Node]`.

executorch/backends/arm/quantizer/quantization_annotation/generic_annotator.py:85:58 Incompatible parameter type [6]: In call `torch.ao.quantization.quantizer.quantizer.SharedQuantizationSpec.__init__`, for 1st positional argument, expected `Union[Tuple[Node, Node], Node]` but got `Tuple[Union[List[Node], Node], typing.Any]`.

Apologies for the delay on this! It should be fixed now.

Thanks,
Saoirse

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit b8e0ef9 into pytorch:main Nov 6, 2024
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SaoirseARM @facebook-github-bot @digantdesai